-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not deep convert buffers #126
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,9 +18,7 @@ const cache = new QuickLru({maxSize: 100_000}); | |
const isObject = value => | ||
typeof value === 'object' | ||
&& value !== null | ||
&& !(value instanceof RegExp) | ||
&& !(value instanceof Error) | ||
&& !(value instanceof Date); | ||
&& (Array.isArray(value) || Object.getPrototypeOf(value) === Object.prototype); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And I think the behavior should be documented. |
||
|
||
const transform = (input, options = {}) => { | ||
if (!isObject(input)) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name here no longer makes any sense.