fix: do not deep convert buffers #126
Conversation
index.js
Outdated
| @@ -20,7 +21,8 @@ const isObject = value => | |||
| && value !== null | |||
| && !(value instanceof RegExp) | |||
| && !(value instanceof Error) | |||
| && !(value instanceof Date); | |||
| && !(value instanceof Date) | |||
| && !(value instanceof Buffer); | |||
There was a problem hiding this comment.
Actually, not just Buffer. It should detect any TypedArray
There was a problem hiding this comment.
@sindresorhus True. I was actually thinking if this lib should not convert any class instances but just arrays and plain objects. I've adjusted the implementation. If we want to check typed arrays, we could do ArrayBuffer.isView(), which is true for TypedArrays + DataViews (which we probably also want to exclude).
| && !(value instanceof RegExp) | ||
| && !(value instanceof Error) | ||
| && !(value instanceof Date); | ||
| && (Array.isArray(value) || Object.getPrototypeOf(value) === Object.prototype); |
There was a problem hiding this comment.
Move Object.getPrototypeOf(value) === Object.prototype out into a const function to improve readability by giving it a name.
There was a problem hiding this comment.
And I think the behavior should be documented.
| @@ -18,9 +18,7 @@ const cache = new QuickLru({maxSize: 100_000}); | |||
| const isObject = value => | |||
There was a problem hiding this comment.
The name here no longer makes any sense.
Buffers are traversed recursively but they shouldn't. I think it's also relevant for other related packages.