-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix variants, add tests #143
base: master
Are you sure you want to change the base?
Conversation
Thanks Matthijs , I really hope to find time soon to review all pending PRs on this project, was very very busy lately |
This is e.g. for variants, and includes the small optimization for the simplest cases that's currently done in marshall.
Just letting you know that I no longer care about this PR. I wrote my own dbus module instead. |
@mvduin Sorry to hear that. I'm happy to add link to your module from readme here |
@sidorares : can this be merged if the conflict is resolved? This is helpful for eslint, so I'd like to merge it before prettifying. |
So obviously that didn't happen, but I'd still like to see a fix for variants. Can you review it @sidorares |
@sidorares : so how about this one? |
They were apparently quite broken...
before:
after: