Fix a number of bugs #227
Merged
Fix a number of bugs #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Q and promises
All messages, including errors and replies, must have serials, and serials must be unique and increasing.
A variant of a struct must have signature starting with '(' -
multiple values in a single variant is invalid. Conversely, a
variant of a single value can have a signature with length > 1,
if the type is a composite type.
In turn, that means the whole expression made no sense and should be killed.
ghost
reviewed
Mar 23, 2018
| @@ -1,3 +1,5 @@ | |||
| // -*- mode: js; c-basic-offset: 2; js-basic-offset: 2 -*- | |||
|
|
|||
|
Other than the modeline thing, are there any other comments on the patch? Or any chance it will be merged eventually? |
|
looks good, sorry it was hanging for so long |
|
Oh great, thank you! |
|
Can you confirm if it actually fixes issues and I'll close those? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are bugs that I found over the course of using dbus-native.
I thought dbus-native was unmantained, but I'm seeing activity recently so I hope these can be merged so I don't need to keep the fork alive.
Each commit is a different bug.