Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only create TextTrack of SimpleTextDisplayer when necessary #7913

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Only create TextTrack of SimpleTextDisplayer when necessary #7913

wants to merge 1 commit into from
+75 −10

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 20, 2025 •
edited
Loading

Fixes #7912

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels Jan 20, 2025
@avelad avelad added this to the v4.13 milestone Jan 20, 2025
@avelad avelad mentioned this pull request Jan 20, 2025
Open
@avelad avelad force-pushed the textrack-SimpleTextDisplayer branch from b9ed66d to 2cbeceb Compare January 20, 2025 15:09
@avelad avelad force-pushed the textrack-SimpleTextDisplayer branch from 2cbeceb to c68fe35 Compare January 20, 2025 15:29
@avelad avelad requested review from theodab and tykus160 January 20, 2025 15:43
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 94.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodab theodab Awaiting requested review from theodab

@tykus160 tykus160 Awaiting requested review from tykus160

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.

Unusual "(Shaka Player TextTrack)" option showing up on iOS during fullscreen playback on the Shaka demo page
2 participants
@avelad @shaka-bot