Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusual "(Shaka Player TextTrack)" option showing up on iOS during fullscreen playback on the Shaka demo page #7912

Closed
koenoe opened this issue Jan 20, 2025 · 9 comments · Fixed by #7913
Assignees
Labels
component: captions/subtitles The issue involves captions or subtitles platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@koenoe
Copy link
Contributor

koenoe commented Jan 20, 2025

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?
Yes

What version of Shaka Player are you using?
4.12.8

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Demo app

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Safari, iOS 18.2.1

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?
Big Buck Bunny (FairPlay)

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?
N/A

What did you do?
Play Big Buck Bunny in the Shaka demo page on a device with iOS 18.2.1, switch to full screen.

What did you expect to happen?
To not have a "(Shaka Player TextTrack)" option

What actually happened?
There's a "(Shaka Player TextTrack)" option, see screenshot:

Image

Are you planning to send a PR to fix it?
I've reviewed the source code to try and identify the issue, but I wasn't able to locate the specific cause.

@koenoe koenoe added the type: bug Something isn't working correctly label Jan 20, 2025
@shaka-bot shaka-bot added this to the v4.13 milestone Jan 20, 2025
@avelad
Copy link
Member

avelad commented Jan 20, 2025

The content does not have CLOSED-CAPTIONS=NONE so Safari always creates a text track. If the content had that tag we would still show it when it is not needed, so I created #7913 to fix that issue.

@avelad avelad added component: captions/subtitles The issue involves captions or subtitles platform: iOS Issues affecting iOS labels Jan 20, 2025
@avelad avelad self-assigned this Jan 20, 2025
@avelad avelad added the priority: P2 Smaller impact or easy workaround label Jan 20, 2025
@koenoe
Copy link
Contributor Author

koenoe commented Jan 27, 2025

Can we reopen this issue please? I can still reproduce this in 4.12.9 and 4.13.0, in both my app and the demo app

Image

@avelad
Copy link
Member

avelad commented Jan 27, 2025

That case you are showing right now is as designed, because you have other text tracks, we have fixed the case where it does not have subtitles and a Shaka subtitle track is still shown.

More info about textDisplayer in https://nightly-dot-shaka-player-demo.appspot.com/docs/api/tutorial-text-displayer.html

And the code that choose the textDisplayer https://github.com/shaka-project/shaka-player/blob/main/lib/player.js#L6594-L6607

@koenoe
Copy link
Contributor Author

koenoe commented Jan 27, 2025

Ah fair enough, I think 4.6.0 introduced this behaviour indeed. Is there a way to go back to how it was in versions before < 4.6.0?

This is what I see in 4.5.0:

Image

I think this change added the "(Shaka Player TextTrack)". Is there a way to filter this out as this looks a bit odd and confusing to the user?

@avelad
Copy link
Member

avelad commented Jan 27, 2025

We have recently made two changes that may affect, #6985 and #7569

@avelad
Copy link
Member

avelad commented Jan 27, 2025

And #6935

@koenoe
Copy link
Contributor Author

koenoe commented Jan 27, 2025

In my understanding when I don't set a video container as described in the docs https://nightly-dot-shaka-player-demo.appspot.com/docs/api/tutorial-text-displayer.html it should use the SimpleTextDisplayer and therefore use native text track rendering. However, I still get the "stub" in my subtitles menu, I struggle to understand how this is as designed as it's not doing anything?

@avelad
Copy link
Member

avelad commented Jan 27, 2025

SimpleTextDisplayer which uses browser's native cue renderer. Shaka Player creates a custom text track attached to the video element and provides necessary data so video element can render it. This is the default displayer when shaka UI is not used.

It indicates that SimpleTextDisplayer creates a track for managing subtitles.

@koenoe
Copy link
Contributor Author

koenoe commented Jan 27, 2025

Ok I'll dive deeper into this, but I struggle to understand this change that introduced this new behaviour: https://github.com/shaka-project/shaka-player/pull/5806/files

In my opinion a "(Shaka Player TextTrack)" option that doesn't do anything in fullscreen is highly confusing for a user and I find it odd there's no way to disable this behaviour, but I might be missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: captions/subtitles The issue involves captions or subtitles platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants