Copasi javascript support #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JavaScript library. This new feature in SEEK enables interpreting COPASI-supported models directly in the client using this library.
…ted with a model.
…application) when multiple items are associated with a model.
…ser has the right to download the asset.
…e current user, use SpecialAuthCode to enable loading the model into CopasiUI (desktop application)
…lation page. These parameters can now be included when running model simulations, providing enhanced flexibility in configuration.
…ls that are not publicly accessible but available for download by the current user, requiring a special authentication code.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
stuzart
requested changes
Oct 14, 2024
| @@ -40,6 +40,6 @@ def jws_online_logo | |||
| end | |||
|
|
|||
| def show_copasi_button? | |||
| Seek::Config.copasi_enabled && (@display_model.policy.access_type == Policy::ALL_USERS) && @display_model.is_copasi_supported? | |||
| Seek::Config.copasi_enabled && @display_model.is_copasi_supported? && @display_model.is_downloadable? && @display_model.can_download?(current_user) | |||
There was a problem hiding this comment.
this duplicates and could reuse @display_model.can_run_copasi?
There was a problem hiding this comment.
can_run_copasi? is defined for the "model" model, can not be called by @display_model ( versioning model)
stuzart
previously approved these changes
Oct 17, 2024
stuzart
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1939