Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] sync-halo2-lib-0.4.0 #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] sync-halo2-lib-0.4.0 #29

wants to merge 1 commit into from

Conversation

zhenfeizhang
Copy link
Contributor

No description provided.

@zhenfeizhang zhenfeizhang mentioned this pull request Oct 16, 2023
Closed
@lispc lispc marked this pull request as ready for review October 24, 2023 01:43
@lispc lispc requested a review from noel2004 October 24, 2023 01:43
noel2004
noel2004 approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@noel2004 noel2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, I notice that some FieldExt have been updated to PrimeField while some other are updated to FromUniformBytes<64>, what is the different between this two types?

@zhenfeizhang
Copy link
Contributor Author

the new ff v0.13.0 does not have the FieldExt trait. They are now replace with PrimeField + FromUniformBytes + Ord + ... for better abstraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noel2004 noel2004 noel2004 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenfeizhang @noel2004