Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to ff/group 0.13.0 #13

Closed
wants to merge 8 commits into from
Closed

Conversation

zhenfeizhang
Copy link
Contributor

No description provided.

@naure naure self-requested a review March 16, 2023 15:44
@noel2004 noel2004 mentioned this pull request Mar 21, 2023
Copy link
Contributor

@naure naure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides couple of comments.

rust-toolchain Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@naure
Copy link
Contributor

naure commented Mar 22, 2023

I resolved the conflict with recent changes in main. Please let me know whether that works for you.

@noel2004
Copy link
Member

noel2004 commented Apr 8, 2023

Now I have merged the main branch (with septidon refactoring) in it and the code seems work now

For the special dependency of halo2 lib (halo2-ecc-snark-verifier-0220), I think it is still not able to be merged into main branch. Just kept it here until our halo2 lib dependency become stable

@noel2004 noel2004 requested a review from naure April 8, 2023 07:21
@zhenfeizhang
Copy link
Contributor Author

replaced with #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants