-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add publint to check on package json and avoid mistakes #4383
base: main
Are you sure you want to change the base?
Conversation
|
707f07f
to
bc4e1db
Compare
packages/ui/package.json
Outdated
@@ -18,7 +18,8 @@ | |||
"typecheck": "tsc --noEmit", | |||
"size": "size-limit", | |||
"test:unit": "LC_ALL=en_US.UTF-8 pnpm vitest --run --config vite.config.ts", | |||
"test:unit:coverage": "pnpm test:unit --coverage" | |||
"test:unit:coverage": "pnpm test:unit --coverage", | |||
"publint": "npx publint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
si on l'utilise dans la ci + husky, tu peux l'installer dans le package root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai mis dans le package root + sub package dans le cas ou tu veux le run localement, et pas bete pour husky je vais l'ajouter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually not the best idea, publint needs a build in order to check exports matches the build folder. If I was to add it into husky before commit it will need to build all packages locally
ea2e849
to
6b3f5d5
Compare
6b3f5d5
to
fc3287f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4383 +/- ##
=======================================
Coverage ? 86.76%
=======================================
Files ? 318
Lines ? 11640
Branches ? 3230
=======================================
Hits ? 10100
Misses ? 1540
Partials ? 0 Continue to review full report in Codecov by Sentry.
|
Summary
Type
Summarise concisely:
What is expected?
Implement Publint in our github action to check on package.json and avoid making mistakes while exporting packages.