Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add publint to check on package json and avoid mistakes #4383

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: add publint to check on package json and avoid mistakes #4383

wants to merge 2 commits into from

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • CI

Summarise concisely:

What is expected?

Implement Publint in our github action to check on package.json and avoid making mistakes while exporting packages.

@matthprost matthprost added enhancement New feature or request ci labels Oct 23, 2024
@matthprost matthprost self-assigned this Oct 23, 2024
@matthprost matthprost requested a review from a team as a code owner October 23, 2024 09:23
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8abfb3a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

philibea
philibea reviewed Oct 23, 2024
View reviewed changes
packages/ui/package.json Outdated
@@ -18,7 +18,8 @@
"typecheck": "tsc --noEmit",
"size": "size-limit",
"test:unit": "LC_ALL=en_US.UTF-8 pnpm vitest --run --config vite.config.ts",
"test:unit:coverage": "pnpm test:unit --coverage"
"test:unit:coverage": "pnpm test:unit --coverage",
"publint": "npx publint"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si on l'utilise dans la ci + husky, tu peux l'installer dans le package root

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai mis dans le package root + sub package dans le cas ou tu veux le run localement, et pas bete pour husky je vais l'ajouter

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually not the best idea, publint needs a build in order to check exports matches the build folder. If I was to add it into husky before commit it will need to build all packages locally

@matthprost matthprost force-pushed the ci/publint branch 3 times, most recently from ea2e849 to 6b3f5d5 Compare October 23, 2024 09:38
@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1ade043). Learn more about missing BASE report.
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4383   +/-   ##
=======================================
  Coverage        ?   86.76%           
=======================================
  Files           ?      318           
  Lines           ?    11640           
  Branches        ?     3230           
=======================================
  Hits            ?    10100           
  Misses          ?     1540           
  Partials        ?        0

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ade043...fc3287f. Read the comment docs.

@matthprost matthprost requested review from philibea, a team and DorianMaliszewski and removed request for a team October 23, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisalupi lisalupi lisalupi approved these changes

@philibea philibea Awaiting requested review from philibea

@DorianMaliszewski DorianMaliszewski Awaiting requested review from DorianMaliszewski DorianMaliszewski was automatically assigned from scaleway/console

At least 2 approving reviews are required to merge this pull request.

Assignees

@matthprost matthprost

Labels
ci enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthprost @philibea @lisalupi @scaleway-bot