ci: add publint to check on package json and avoid mistakes

scaleway · Oct 23, 2024 · bc4e1db · bc4e1db
1 parent 1ade043
commit bc4e1db
Show file tree

Hide file tree

Showing 9 changed files with 38 additions and 12 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -25,6 +25,22 @@ jobs:
       - run: |
           pnpm install
           pnpm exec manypkg check
+  publint:
+    runs-on: ubuntu-24.04
+    env:
+      TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
+      TURBO_REMOTE_ONLY: true
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pnpm/[email protected]
+      - name: Use Node.js
+        uses: actions/[email protected]
+        with:
+          node-version: 20
+          cache: "pnpm"
+      - run: |
+          pnpm install
+          pnpm publint
   typecheck:
     runs-on: ubuntu-24.04
     env:
@@ -82,7 +98,7 @@ jobs:
     env:
       TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
       TURBO_REMOTE_ONLY: true
-    needs: [typecheck, format]
+    needs: [publint, typecheck, format]
     strategy:
       matrix:
         node: ["20"]
@@ -129,7 +145,7 @@ jobs:
     env:
       TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
       TURBO_REMOTE_ONLY: true
-    needs: [typecheck, format]
+    needs: [publint, typecheck, format]
     steps:
       - uses: actions/checkout@v4 # v4.1.4
       - uses: pnpm/[email protected]
@@ -148,7 +164,7 @@ jobs:
       DEPLOYMENT_NAME: "storybook"
       TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
       TURBO_REMOTE_ONLY: true
-    needs: [typecheck, build]
+    needs: [publint, typecheck, build]
     steps:
       - uses: actions/checkout@v4
       - name: Inject slug/short variables

diff --git a/package.json b/package.json
@@ -34,7 +34,8 @@
     "release": "pnpm build && pnpm changeset publish",
     "svg": "npx svgo --pretty --multipass",
     "svg:all": "pnpm run svg -r -f .",
-    "illustrations:update": "BUCKET_NAME=ultraviolet BUCKET_REGION=fr-par node utils/illustrations/uploadIllustrations.js && pnpm format packages/illustrations/src/"
+    "illustrations:update": "BUCKET_NAME=ultraviolet BUCKET_REGION=fr-par node utils/illustrations/uploadIllustrations.js && pnpm format packages/illustrations/src/",
+    "publint": "turbo publint"
   },
   "lint-staged": {
     "*.(j|t|mj)s?(x)": [

diff --git a/packages/form/package.json b/packages/form/package.json
@@ -18,7 +18,8 @@
     "type:generate": "tsc --declaration -p tsconfig.build.json",
     "typecheck": "tsc --noEmit",
     "watch:build": "vite build --config vite.config.ts --watch",
-    "watch": "pnpm run '/^watch:.*/'"
+    "watch": "pnpm run '/^watch:.*/'",
+    "publint": "npx publint"
   },
   "keywords": [
     "react",

diff --git a/packages/icons/package.json b/packages/icons/package.json
@@ -16,7 +16,8 @@
     "build": "vite build --config vite.config.ts && pnpm run type:generate",
     "build:profile": "npx vite-bundle-visualizer -c vite.config.ts",
     "typecheck": "tsc --noEmit",
-    "size": "size-limit"
+    "size": "size-limit",
+    "publint": "npx publint"
   },
   "keywords": [
     "react",

diff --git a/packages/illustrations/package.json b/packages/illustrations/package.json
@@ -18,7 +18,8 @@
     "typecheck": "tsc --noEmit",
     "size": "size-limit",
     "test:unit": "LC_ALL=en_US.UTF-8 pnpm vitest --run --config vite.config.ts",
-    "test:unit:coverage": "pnpm test:unit --coverage"
+    "test:unit:coverage": "pnpm test:unit --coverage",
+    "publint": "npx publint"
   },
   "keywords": [
     "illustrations",
@@ -68,7 +69,7 @@
     "./various": {
       "types": "./dist/assets/various/index.d.ts",
       "require": "./dist/assets/various/index.cjs",
-      "default": "./dist/various/index.js"
+      "default": "./dist/assets/various/index.js"
     },
     "./components": {
       "types": "./dist/components/index.d.ts",

diff --git a/packages/plus/package.json b/packages/plus/package.json
@@ -18,7 +18,8 @@
     "typecheck": "tsc --noEmit",
     "size": "size-limit",
     "test:unit": "LC_ALL=en_US.UTF-8  pnpm vitest --run --config vite.config.ts",
-    "test:unit:coverage": "pnpm test:unit --coverage"
+    "test:unit:coverage": "pnpm test:unit --coverage",
+    "publint": "npx publint"
   },
   "keywords": [
     "react",

diff --git a/packages/themes/package.json b/packages/themes/package.json
@@ -15,7 +15,8 @@
     "watch:build": "vite build --config vite.config.ts --watch",
     "build": "vite build --config vite.config.ts && pnpm run type:generate",
     "build:profile": "npx vite-bundle-visualizer -c vite.config.ts",
-    "typecheck": "tsc --noEmit"
+    "typecheck": "tsc --noEmit",
+    "publint": "npx publint"
   },
   "keywords": [
     "themes",
@@ -41,13 +42,13 @@
   "types": "./dist/index.d.ts",
   "main": "./dist/index.cjs",
   "exports": {
-    "./*.css": "./dist/style/*.css",
     ".": {
       "types": "./dist/index.d.ts",
       "require": "./dist/index.cjs",
       "import": "./dist/index.js",
       "default": "./dist/index.js"
     },
+    "./*.css": "./dist/style/*.css",
     "./console/*": {
       "types": "./dist/themes/console/*/index.d.ts",
       "require": "./dist/themes/console/*/index.cjs",

diff --git a/packages/ui/package.json b/packages/ui/package.json
@@ -18,7 +18,8 @@
     "typecheck": "tsc --noEmit",
     "size": "size-limit",
     "test:unit": "LC_ALL=en_US.UTF-8  pnpm vitest --run --config vite.config.ts",
-    "test:unit:coverage": "pnpm test:unit --coverage"
+    "test:unit:coverage": "pnpm test:unit --coverage",
+    "publint": "npx publint"
   },
   "keywords": [
     "react",

diff --git a/turbo.json b/turbo.json
@@ -29,6 +29,9 @@
         "storybook-static/**"
       ]
     },
+    "publint": {
+      "dependsOn": []
+    },
     "size": {
       "dependsOn": ["build"]
     },