Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for payable address #18

Open
wants to merge 8 commits into
base: publish
Choose a base branch
from

Conversation

maxsam4
Copy link

@maxsam4 maxsam4 commented Dec 27, 2018

Added support for payable address. Added test case as well.
props to @duaraghav8 for the original fix in solparse.

@maxsam4
Copy link
Author

maxsam4 commented Dec 27, 2018

Those who want to use solidity-coverage with solidity 0.5 immediately can get the build parser file from https://raw.githubusercontent.com/maxsam4/solidity-parser/solidity-0.5/build/parser.js and replace the one in your node modules.

The above file combines this PR and #17

@BlinkyStitt
Copy link

How do we get someone with access to merge this to review?

@angus-hamill
Copy link

@wysenynja it appears the only one with write access is @cgewecke who hasn't been active for months. I dropped him an email but he hasn't responded

@pedrobranco
Copy link

I'm also waiting for #17 and #18.

It has been months since last online activity of @cgewecke. Time to fork the solidity-parser and dependencies like this one? 😬

Maybe the next fork should have more than one maintainer to prevent these situations 😕

@maxsam4
Copy link
Author

maxsam4 commented Mar 2, 2019

Fixed parsing of uint256[] memory yolo = abi.decode(_world, (uint256[]));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants