Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade solc to 0.5.x #70

Merged
merged 8 commits into from
Jan 3, 2019
Merged

Upgrade solc to 0.5.x #70

merged 8 commits into from
Jan 3, 2019

Conversation

mrice32
Copy link
Member

@mrice32 mrice32 commented Dec 28, 2018

Upgrade to Solidity version 0.5.0. There are a few caveats with this change.

  • We're using a release candidate of open zeppelin because they haven't done a stable release of 0.5.0 compatible contracts. We'll move to the real release once that's out.
  • The maintainer of the solidity-coverage tool doesn't seem to be doing much work on it anymore. It works well, but the solidity parser it uses (forked and maintained by the same maintainer) hasn't been updated to work with 0.5.0. There's a PR out to update the parser, but it hasn't been reviewed or merged. Until that happens, we'll be manually replacing the package with the code from that PR (Added support for payable address sc-forks/solidity-parser#18 (comment)).

This compiler/language update contains a lot of breaking changes, so I also upgraded any packages that might depend on the output of the compiler in some way.

@mrice32 mrice32 changed the title Upgrade the used solc to 0.5.x Upgrade solc to 0.5.x Jan 3, 2019
@mrice32 mrice32 merged commit 0275f03 into master Jan 3, 2019
@mrice32 mrice32 deleted the upgrade_solc branch January 3, 2019 15:44
mrice32 added a commit that referenced this pull request Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants