Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ReferenceSequenceFile.getSubsequenceAt(final Locatable locatable ) shortcut to getSubsequenceAt(loc.getContig(), loc.getStart(), loc.getEnd()) #1725

Merged
merged 1 commit into from
Oct 28, 2024
Merged

add ReferenceSequenceFile.getSubsequenceAt(final Locatable locatable ) shortcut to getSubsequenceAt(loc.getContig(), loc.getStart(), loc.getEnd()) #1725

merged 1 commit into from
Oct 28, 2024

Conversation

lindenb
Copy link
Contributor

@lindenb lindenb commented Oct 28, 2024 •
edited
Loading

Description

A small PR that adds a default method to ReferenceSequenceFile.java

getSubsequenceAt(final Locatable loc )

shortcut to

getSubsequenceAt(loc.getContig(), loc.getStart(), loc.getEnd())

Things to think about before submitting:

  • Make sure your changes compile and new tests pass locally
  • Add new tests or update existing ones:
  • Extended the README / documentation, if necessary
  • Check your code style.
  • Write a clear commit title and message

@lindenb lindenb marked this pull request as ready for review October 28, 2024 13:54
lbergelson
lbergelson approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lindenb Seems like a good idea to me! Thank you.

@lbergelson lbergelson merged commit fd56496 into samtools:master Oct 28, 2024
4 checks passed
@lindenb lindenb deleted the pl_reference_locatable branch October 28, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbergelson lbergelson lbergelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lindenb @lbergelson