Update snappy-java and migrate mjson to org.json to address CVEs #1670
+97
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbimber Thank you! |
lbergelson
reviewed
Jul 28, 2023
|
@lbergelson were there any other changes you needed on this? Also, and this isnt urgent, but is there a defined release schedule on htsjdk? Thanks. |
|
Ack, I had it set to rebase instead of squash. Sorry for commit spam. |
|
Thanks for doing this. I was thinking of doing a release very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are CVEs reported for mjson, which does not appear to be an actively maintained project:
https://nvd.nist.gov/vuln/detail/CVE-2023-34611
bolerio/mjson#40
and also snappy-java:
https://nvd.nist.gov/vuln/detail/CVE-2023-34453
https://nvd.nist.gov/vuln/detail/CVE-2023-34455
the latest snappy-java has been patched.
This PR does two things: