-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add new design for search results page(no results found) #2224
Feat: Add new design for search results page(no results found) #2224
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel. @rupali-codes first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, heysolomon, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @heysolomon, please make the following changes
- Remove extra space in sidebar,
- Shift the heading to left
- Reduce vertical adding in
join discord
button - Increase side of the arrow in
join discord
button
Thanks for contributing :)
Okay, making the fixes |
@rupali-codes I have made the changes
Note to reviewers
|
Yeah, tailwind merge is very useful and addition will just benefit in the longer run. |
Yeah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR, @heysolomon 💪 🚀 💯
It just needs minor adjustments and then we're good to go 🚀
removed comment on Button variant Primary Co-authored-by: Aftab Rehan <[email protected]>
Co-authored-by: Aftab Rehan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heysolomon can you reduce the space between the search icon the top-heading
Sorry I don't clearly understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heysolomon i'm talking about this
- reduce size of the icon
- put some space around the icon
- make the button like earlier (voilet)
Oh! okay. Working on it |
@rupali-codes and @Anmol-Baranwal, I fixed the button color, icon size and spacing. Here are screenshots of different views Please let me know if there's any other thing I need to fix |
@rupali-codes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR, @heysolomon 💪 🚀 💯
@Anmol-Baranwal and @CBID2 please help review and merge this PR. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too
Fixes Issue
This PR closes #2175
Changes proposed
Screenshots
Note to reviewers
tailwind.config.js
file by adding new colors that were used for building the Search page