Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add new design for search results page(no results found) #2224

Merged

Conversation

heysolomon
Copy link
Contributor

Fixes Issue

This PR closes #2175

Changes proposed

  • added the new design for the search results page(no results found)

Screenshots

image

Note to reviewers

  • made an update to the tailwind.config.js file by adding new colors that were used for building the Search page

Copy link

vercel bot commented Dec 27, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, heysolomon, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 0:00am

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @heysolomon, please make the following changes

  • Remove extra space in sidebar,
  • Shift the heading to left
  • Reduce vertical adding in join discord button
  • Increase side of the arrow in join discord button

Thanks for contributing :)

@heysolomon
Copy link
Contributor Author

hey @heysolomon, please make the following changes

  • Remove extra space in sidebar,
  • Shift the heading to left
  • Reduce vertical adding in join discord button
  • Increase side of the arrow in join discord button

Thanks for contributing :)

Okay, making the fixes

@heysolomon
Copy link
Contributor Author

hey @heysolomon, please make the following changes

  • Remove extra space in sidebar,
  • Shift the heading to left
  • Reduce vertical adding in join discord button
  • Increase side of the arrow in join discord button

Thanks for contributing :)

@rupali-codes I have made the changes

  • Remove extra space in sidebar,
  • Shift the heading to left
  • Reduce vertical adding in join discord button
  • Increase size of the arrow in join discord button

Note to reviewers

  • I noticed the styles weren't taking effect when I tried reducing the vertical padding of the Button component in the className. I didn't want to change the padding in the component because I didn't know if the Button component was used elsewhere in the code. Ideally, my new styles are supposed to override the old ones. So, I added a tailwind package, tailwind-merge a utility function to merge Tailwind CSS classes efficiently in JS without style conflicts.

@Anmol-Baranwal
Copy link
Collaborator

hey @heysolomon, please make the following changes

  • Remove extra space in sidebar,
  • Shift the heading to left
  • Reduce vertical adding in join discord button
  • Increase side of the arrow in join discord button

Thanks for contributing :)

@rupali-codes I have made the changes

  • Remove extra space in sidebar,
  • Shift the heading to left
  • Reduce vertical adding in join discord button
  • Increase size of the arrow in join discord button

Note to reviewers

  • I noticed the styles weren't taking effect when I tried reducing the vertical padding of the Button component in the className. I didn't want to change the padding in the component because I didn't know if the Button component was used elsewhere in the code. Ideally, my new styles are supposed to override the old ones. So, I added a tailwind package, tailwind-merge a utility function to merge Tailwind CSS classes efficiently in JS without style conflicts.

Yeah, tailwind merge is very useful and addition will just benefit in the longer run.

@heysolomon
Copy link
Contributor Author

hey @heysolomon, please make the following changes

  • Remove extra space in sidebar,
  • Shift the heading to left
  • Reduce vertical adding in join discord button
  • Increase side of the arrow in join discord button

Thanks for contributing :)

@rupali-codes I have made the changes

  • Remove extra space in sidebar,
  • Shift the heading to left
  • Reduce vertical adding in join discord button
  • Increase size of the arrow in join discord button

Note to reviewers

  • I noticed the styles weren't taking effect when I tried reducing the vertical padding of the Button component in the className. I didn't want to change the padding in the component because I didn't know if the Button component was used elsewhere in the code. Ideally, my new styles are supposed to override the old ones. So, I added a tailwind package, tailwind-merge a utility function to merge Tailwind CSS classes efficiently in JS without style conflicts.

Yeah, tailwind merge is very useful and addition will just benefit in the longer run.

Yeah

Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR, @heysolomon 💪 🚀 💯

It just needs minor adjustments and then we're good to go 🚀

tailwind.config.js Outdated Show resolved Hide resolved
components/Button/Button.tsx Outdated Show resolved Hide resolved
components/Button/Button.tsx Show resolved Hide resolved
components/NotFound/NotFound.tsx Outdated Show resolved Hide resolved
heysolomon and others added 2 commits December 30, 2023 12:20
removed comment on Button variant Primary

Co-authored-by: Aftab Rehan <[email protected]>
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heysolomon can you reduce the space between the search icon the top-heading

image

@heysolomon
Copy link
Contributor Author

@heysolomon can you reduce the space between the search icon the top-heading

image

Sorry I don't clearly understand.

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heysolomon i'm talking about this

image

  • reduce size of the icon
  • put some space around the icon
  • make the button like earlier (voilet)

@Anmol-Baranwal Anmol-Baranwal linked an issue Jan 3, 2024 that may be closed by this pull request
@Anmol-Baranwal
Copy link
Collaborator

image

Like this 👀

@heysolomon
Copy link
Contributor Author

@heysolomon i'm talking about this

image

  • reduce size of the icon
  • put some space around the icon
  • make the button like earlier (voilet)

Oh! okay. Working on it

@heysolomon
Copy link
Contributor Author

heysolomon commented Jan 4, 2024

@rupali-codes and @Anmol-Baranwal, I fixed the button color, icon size and spacing.

Here are screenshots of different views
image
Screenshot 2024-01-04 122725
Screenshot 2024-01-04 122744

Please let me know if there's any other thing I need to fix

@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes
Please check.

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR, @heysolomon 💪 🚀 💯

@aftabrehan aftabrehan added goal: new-design Design related issues status: ready-to-merge Approved & its ready-to-merge priority: high Making completely new feature labels Jan 8, 2024
@aftabrehan
Copy link
Collaborator

@Anmol-Baranwal and @CBID2 please help review and merge this PR. Thank you!

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too

@rupali-codes rupali-codes merged commit e895674 into rupali-codes:dev Jan 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-design Design related issues priority: high Making completely new feature status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add new design for search results page (no results found)
5 participants