Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new design for search results page (no results found) #2175

Closed
Anmol-Baranwal opened this issue Nov 1, 2023 · 14 comments · Fixed by #2224
Closed

feat: add new design for search results page (no results found) #2175

Anmol-Baranwal opened this issue Nov 1, 2023 · 14 comments · Fixed by #2224
Assignees
@heysolomon
Labels
development Still being developed goal: new-design Design related issues 🚀 ready

Comments

@Anmol-Baranwal
Copy link
Collaborator

Anmol-Baranwal commented Nov 1, 2023 •
edited by rupali-codes
Loading

You can view the figma file here.

image

The design should be responsive.

ℹ️ We recommend updating the styling of existing components, otherwise you can add extra components if there is a need.

  • You need to implement the above design.

Any changes to the above design are welcome. Please feel free to share your thoughts, and we will discuss them thoroughly.

⚠️ Make sure to push all the changes into dev branch
@Anmol-Baranwal Anmol-Baranwal mentioned this issue Nov 1, 2023
Closed
11 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label, 🚀 ready.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Hello Anmol-Baranwal!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@Anmol-Baranwal Anmol-Baranwal changed the title Search Results Page (No results found) feat: add new design for search results page (no results found) Nov 1, 2023
@rupali-codes rupali-codes added goal: new-design Design related issues development Still being developed up for grabs this issue open for the taking 🚀 ready and removed 🔒 locked labels Nov 2, 2023
Repository owner unlocked this conversation Nov 2, 2023
@SandeepGumaste
Copy link

Can I work on this and? @rupali-codes @Anmol-Baranwal

@Anmol-Baranwal
Copy link
Collaborator Author

@SandeepGumaste
I have assigned you the issue. Please proceed with it, and don't hesitate to tag maintainers if you require any assistance.

Also, remember to switch to dev mode. It will be easier for development.

Top right corner in figma file
image

@Anmol-Baranwal Anmol-Baranwal removed the up for grabs this issue open for the taking label Nov 5, 2023
@SandeepGumaste
Copy link

SandeepGumaste commented Nov 5, 2023 •
edited
Loading

Didn't find the search icon in react-icons which is already used in the project and also couldn't download the icon from figma because export is enabled only for editors. Are the icons used in the new ui are from some icon pack that I can install? @Anmol-Baranwal @rupali-codes

@Anmol-Baranwal
Copy link
Collaborator Author

Anmol-Baranwal commented Nov 5, 2023 •
edited
Loading

Didn't find the search icon in react-icons which is already used in the project and also couldn't download the icon from figma because export is enabled only for editors. Are the icons used in the new ui are from some icon pack that I can install? @Anmol-Baranwal @rupali-codes

Wait, giving you the icon. The icon pack used is react-icons. You can use local icon when provided by us.

@Anmol-Baranwal
Copy link
Collaborator Author

@SandeepGumaste
You can now export the icons and use it. It's properly working.

@rupali-codes
Copy link
Owner

@SandeepGumaste any updates? Are you still willing to work on this?

@SandeepGumaste
Copy link

Will submit a pull request in some time today. @rupali-codes

@rupali-codes
Copy link
Owner

Will submit a pull request in some time today. @rupali-codes

@SandeepGumaste ?

@heysolomon
Copy link
Contributor

Hey @rupali-codes can I jump on this?

@CBID2 CBID2 assigned heysolomon and unassigned SandeepGumaste Dec 26, 2023
@CBID2
Copy link
Collaborator

CBID2 commented Dec 26, 2023

Hey @rupali-codes can I jump on this?

You're assigned @heysolomon! :)

@heysolomon
Copy link
Contributor

Hey @rupali-codes can I jump on this?

You're assigned @heysolomon! :)

okay thank you!

@heysolomon heysolomon mentioned this issue Dec 26, 2023
Closed
heysolomon added a commit to heysolomon/LinksHub that referenced this issue Dec 27, 2023
@heysolomon
feat: Add new design for search results page (rupali-codes#2175)
c07a1cd
@heysolomon heysolomon mentioned this issue Dec 27, 2023
Merged
@Anmol-Baranwal Anmol-Baranwal linked a pull request Jan 3, 2024 that will close this issue
Feat: Add new design for search results page(no results found) #2224
Merged
rupali-codes pushed a commit that referenced this issue Jan 10, 2024
@heysolomon @aftabrehan
Feat: Add new design for search results page(no results found) (#2224)
e895674 
* feat: Add new design for search results page (#2175)

* made sidebar extraspace, heading to left, button arrow size fix

* fixed button vertical padding

* Update components/Button/Button.tsx

removed comment on Button variant Primary

Co-authored-by: Aftab Rehan <[email protected]>

* Update components/NotFound/NotFound.tsx

Co-authored-by: Aftab Rehan <[email protected]>

* removed repeated primary color

* fixed button color

* fixed the icon size and spacing

---------

Co-authored-by: Aftab Rehan <[email protected]>
@Anmol-Baranwal
Copy link
Collaborator Author

Completed with #2224.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heysolomon heysolomon

Labels
development Still being developed goal: new-design Design related issues 🚀 ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Add new design for search results page(no results found) heysolomon/LinksHub
5 participants
@heysolomon @SandeepGumaste @Anmol-Baranwal @rupali-codes @CBID2