Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

右モータの回転方向を修正 #95

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

YusukeKato
Copy link
Contributor

@YusukeKato YusukeKato commented Nov 26, 2024

What does this implement/fix?

右のモータが逆に回転してしまうので修正します。

Does this close any currently open issues?

#94

How has this been tested?

  • サンプルのstep4とstep6を実行して問題ないことを確認しました
  • raspimouse2パッケージを使用してTwistメッセージで直進指令を送った時に直進することを確認しました

Any other comments?

なし。

Checklists

@YusukeKato YusukeKato added the Type: Bug Bug or Bug fixes label Nov 26, 2024
@YusukeKato YusukeKato requested a review from KuraZuzu November 26, 2024 07:45
@YusukeKato YusukeKato self-assigned this Nov 26, 2024
Copy link
Contributor

@KuraZuzu KuraZuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます。LGTMです。

以下の環境で動作を確認しました

  • Raspberry PI 4B (4GB)
  • os: Ubuntu Server 24.04
  • kernel: 6.8.0-1014-raspi

step4.shstep6.shに加え、raspimouse_ros2_examplesのジョイコンでも正しい方向への動作確認ができました。

$ ros2 launch raspimouse_ros2_examples teleop_joy.launch.py joydev:="/dev/input/js0" joyconfig:=f710 mouse:=true

@KuraZuzu KuraZuzu merged commit 831fe3c into master Nov 26, 2024
11 checks passed
@KuraZuzu KuraZuzu deleted the fix-motor-direction branch November 26, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants