-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update section about rmdrive becoming trackdown package #348
Conversation
- Introduce the trackdown package for collaborative writing. - Description of package main features and general workflow. - Example of workflow - Added 3 images TODO missing reference for trackdown package
Thanks for the PR !
trackdown needs to be installed so that However, when I install the package on my system and run the citation function I don't get exactly what is expected it seems (urls are not in url part of the citation...) > toBibtex(utils::citation("trackdown"))
@Manual{,
title = {trackdown: Collaborative Writing and Editing of R Markdown (or Sweave)
Documents in Google Drive},
author = {Emily Kothe and Claudio {Zandonella Callegher} and Filippo Gambarota and Janosch Linkersdörfer and Mathew Ling},
year = {2021},
note = {https://github.com/ekothe/trackdown/,
https://ekothe.github.io/trackdown/},
}
Warning message:
In utils::citation("trackdown") : Possibly because it is not from CRAN ? About CRAN, we could also wait for the package to be on CRAN to update the book section. About the book chapter on trackdown, it is now quite long. The R Markdown Cookbook does not aim to be the place for documenting how to use the package. We added on this in the book to inform users that such package exist and can suits their specific need. You already have a great documentation on https://ekothe.github.io/trackdown/ with a specific article on the workflow example already https://ekothe.github.io/trackdown/articles/trackdown-workflow.html. Having such documentation is several places could make it difficult to keep up to date. So I would probably tend to remove the "workflow example" part and instead point to your documentation or specific part of your documentation. What do you think ? |
- add package citation - remove example workflow - add link to example workflow form original documentation
Hi @cderv, thank you for the quick reply. Regarding packages dependencies, I have added Now if I run
The only remaining issue is that in the rendered book I do not get the same output. Looking at the source code of In the URL field of the
In the function
I have noted that this happens also for other packages (e.g., I would like to keep both URLs in the
I agree with you! In commit 4cddb18 I have removed the workflow example pointing out interested readers to the package documentation. Now the chapter is much shorter.
The JOSS is considering whether or not to review the package (openjournals/joss-reviews#3427). If they accept to review (fingers crossed) I guess that it would require around 3 months or more before the package is on CRAN. In this case, I would prefer to update the chapter section now as the current chapter is still referring to the old version of the package. Instead, if the JOSS refuse to review it, I will submit it to CRAN immediately. In this case, I guess it would take only a couple of weeks so we can wait for the package to be on CRAN before update the chapter. What do you think about this? PS. thanks for pointing out I was missing the |
This is how we handle the multiple URL in DESCRIPTION for our package and their citations https://github.com/rstudio/bookdown/blob/0699af4bc8d4900312945b726bd8896783a9b522/inst/CITATION#L12 You can see we have a special handling for the URL. However, you are right that Maybe This is something for knitr. I'll probably open an issue there. When will you have the JOSS answer ? I think we could still publish like this before CRAN release anyway |
Thanks for your tip! Really interesting method. I love to learn new tricks every day!
I guess JOSS would require a couple of days ~ one week to answer. I agree with you that if it is possible we can just publish and update when the package will be available on CRAN. Thanks for your time! |
@ClaudioZandonella see yihui/knitr#2028 there was a change in |
I don't where we are on the CRAN release or not. I'll merge this PR and you can do one more to update when the package is on CRAN. Thanks ! |
Referring to issue #333
I updated the section referring to the package
rmdrive
now namedtrackdown
. The package received a complete revision, the workflow follows the same idea as before, but there are several new features and changes.The chapter now includes updated documentation:
TODO missing reference for trackdown package. I could not add the bib entry for the package to the
packages.bib
file that is automatically created.