Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trackdown now on cran #355

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Conversation

ClaudioZandonella
Copy link
Contributor

Hi @cderv,

Sorry for the time it took me to send this PR to update the old PR (#348) but it was a really busy month.

Now, the trackdown package is on CRAN (link). I have updated the information to install the package.
Note that I had to update the version of other packages as well because they are trackdown dependencies. In particular,

  • cli 3.0
  • gargle 1.2
  • googledrive 2.0

Moreover, regarding the issue on write_bib() (knitr/issues/2028), the url is still missing from the reference because:

  • although the package is now available on CRAN, the package is actually installed from the RSPM repository using install.packages(). This happens automatically probably for some default settings. As a consequence, the following code is not evaluated

https://github.com/yihui/knitr/blob/d65b9239804163b693cbfa4b774980f3b7d1fecd/R/citation.R#L75-L80

  • if I update knitr to the development version, the code below will process the first url but the url is still set in note = and not in url = (as you already pointed out link). The note field is not printed in the reference.

https://github.com/yihui/knitr/blob/d65b9239804163b693cbfa4b774980f3b7d1fecd/R/citation.R#L102-L105

In the PR I did not updated knitr to the development version to avoid installing through GitHub. Let me know if you prefer I update it.

Thanks for your work!

ClaudioZandonella and others added 2 commits August 17, 2021 09:19
Update required dependencies
- cli 3.0
- gargle 1.2
- googledrive 2.0

Add install info in text
@cderv
Copy link
Collaborator

cderv commented Aug 17, 2021

Thanks!

Yes I see the issue with write_bib(), maybe it needs to support RSPM explicitly. I'll look into it.

@cderv cderv merged commit 11e30fe into rstudio:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants