Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open-loop odometry in case of ref timeout #1454

Merged
merged 4 commits into from
Jan 1, 2025

Conversation

christophfroehlich
Copy link
Contributor

In case of ref timeout the open-loop odometry was wrong: It used the last valid command input instead.

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (97d7475) to head (bf597bf).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...llers_library/src/steering_controllers_library.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
+ Coverage   83.81%   83.84%   +0.03%     
==========================================
  Files         122      122              
  Lines       11122    11119       -3     
  Branches      946      943       -3     
==========================================
+ Hits         9322     9323       +1     
  Misses       1489     1489              
+ Partials      311      307       -4     
Flag Coverage Δ
unittests 83.84% <80.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...llers_library/src/steering_controllers_library.cpp 79.72% <80.00%> (ø)

... and 4 files with indirect coverage changes

saikishor
saikishor previously approved these changes Dec 29, 2024
bmagyar
bmagyar previously approved these changes Jan 1, 2025
destogl
destogl previously approved these changes Jan 1, 2025
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@destogl destogl dismissed stale reviews from bmagyar, saikishor, and themself via a16b7a7 January 1, 2025 18:30
destogl
destogl previously approved these changes Jan 1, 2025
@christophfroehlich christophfroehlich merged commit 2375aca into master Jan 1, 2025
23 of 24 checks passed
@christophfroehlich christophfroehlich deleted the fix/steering_lib/open_loop branch January 1, 2025 19:09
mergify bot pushed a commit that referenced this pull request Jan 1, 2025
Co-authored-by: Dr. Denis <[email protected]>
(cherry picked from commit 2375aca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants