Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promise.fromEvent takes all of the signal's parameters #186

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Promise.fromEvent takes all of the signal's parameters #186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e09e862
Promise.fromEvent takes all of the signal's parameters
tacheometry Oct 24, 2022
a90f086
Fix array formatting
tacheometry Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions types/Promise.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,12 +570,12 @@ interface PromiseConstructor {
* end)
* ```
*/
fromEvent<T>(this: void, event: RBXScriptSignal<(value: T) => void>, predicate?: (value: T) => boolean): Promise<T>;
fromEvent<T extends Array<any>>(this: void, event: RBXScriptSignal<(...values: T) => void>, predicate?: (...values: T) => boolean): Promise<T>;
fromEvent(this: void, event: RBXScriptSignal<() => void>, predicate?: () => boolean): Promise<void>;
fromEvent<T>(
fromEvent<T extends Array<any>>(
this: void,
event: { Connect: (callback: (value: T) => void) => void },
predicate?: (value: T) => boolean,
event: { Connect: (callback: (...values: T) => void) => void },
predicate?: (...values: T) => boolean,
): Promise<T>;

/** Checks whether the given object is a Promise via duck typing. This only checks if the object is a table and has an `andThen` method. */
Expand Down