Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promise.fromEvent takes all of the signal's parameters #186

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Promise.fromEvent takes all of the signal's parameters #186

wants to merge 2 commits into from

Commits on Oct 24, 2022

  1. Promise.fromEvent takes all of the signal's parameters 

    Promise.fromEvent's predicate only took the first parameter from the RBXScriptSignal. Now it should take all of them.
Before:
https://roblox-ts.com/playground/#code/JYWwDg9gTgLgBAbzgWQIZQNYFMZgDaoDGWAyllAG7DFwC+cAZlBCHAEQACUARgB4wBnAPQDyVYgLYBuAFAyACsxDBRAOiYsAohSwA7GAAo0mHPiKkx1LKsUswMAOKoQWeagED5AVyiEAFu5YAGLAuip+WAAmADRwBmYAnuSxAObOru4CAJIxcADu7t6+AaKRAJRwALwAfIgyAJBCQnBpLm4eOXCoupH5hT7+gb3oWHC6EPBgmVENUDg+unAwUF5YsrRlMkA

```ts
import { MarketplaceService } from "@rbxts/services";

Promise.fromEvent(MarketplaceService.PromptGamePassPurchaseFinished, (player, gamePassId, wasPurchased) => {
	// gamePassId and wasPurchased are not passed
	return true;
})
```

Now, `gamePassId` and `wasPurchased` should be passed.
    @tacheometry
    tacheometry authored Oct 24, 2022
    Configuration menu
    Copy the full SHA
    e09e862 View commit details
    Browse the repository at this point in the history

  2. Fix array formatting

    @tacheometry
    tacheometry authored Oct 24, 2022
    Configuration menu
    Copy the full SHA
    a90f086 View commit details
    Browse the repository at this point in the history