-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): lossy "purify" column default value #19993
Conversation
5f3ec2c
to
72ea3cf
Compare
5d7a9dc
to
9674e8d
Compare
72ea3cf
to
5f8b6ef
Compare
9674e8d
to
4e2ba8c
Compare
5f8b6ef
to
274a032
Compare
4e2ba8c
to
f31c80f
Compare
274a032
to
ec38b32
Compare
f31c80f
to
66cb893
Compare
|
||
return Ok(base); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously we short-circuited the procedure once we find all columns are present. Now we should always go through the step for filling the default value.
ec38b32
to
6ec6062
Compare
34145ee
to
b958c45
Compare
b958c45
to
fc48f02
Compare
fc48f02
to
1126076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
…raint Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
1126076
to
1ebc3b2
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In #19949 we mentioned that
which is the very missing piece of definition purification.
In this PR, we allow converting persisted
DefaultColumnDesc
back toast::ColumnOption::DefaultValue
losslessly, by simply storing the encoded value temporarily into the AST.Apparently this is somehow hacky, as unparsing the AST back to SQL will still lose such information. However, this can still be beneficial for...
get_new_table_definition_for_cdc_table
ALTER TABLE
will refresh previous snapshot values for absent cells #17121 once we adopt the purified definition for replacing job...as long as we believe that AST is the best intermediate representation for schema change.
Checklist
Documentation
Release note