Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columnar APIs: do not autogenerate indicator for Scalar #8771

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 22, 2025

@teh-cmc teh-cmc added 🦀 Rust API Rust logging API 🚀 performance Optimization, memory use, etc do-not-merge Do not merge this PR 🍏 primitives Relating to Rerun primitives exclude from changelog PRs with this won't show up in CHANGELOG.md 🔩 data model labels Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

Web viewer failed to build.

| Result | Commit | Link | Manifest |
| ------ | ------- | ----- |
| ❌ | | https://rerun.io/viewer/pr/8771 | +nightly +main |

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc force-pushed the cmc/show_scalar_snippets branch from a63506c to 23cb734 Compare January 22, 2025 09:24
@teh-cmc teh-cmc force-pushed the cmc/no_scalar_indicator branch from 2e0d26a to d5951ee Compare January 22, 2025 09:25
@Wumpf Wumpf self-requested a review January 22, 2025 09:25
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather brute force, but yeah everything else would be overengineering 🤷

Base automatically changed from cmc/show_scalar_snippets to main January 22, 2025 09:30
@teh-cmc teh-cmc force-pushed the cmc/no_scalar_indicator branch from d5951ee to 16e36cd Compare January 22, 2025 09:36
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Jan 22, 2025
@teh-cmc teh-cmc merged commit 48ce3eb into main Jan 22, 2025
27 of 29 checks passed
@teh-cmc teh-cmc deleted the cmc/no_scalar_indicator branch January 22, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model exclude from changelog PRs with this won't show up in CHANGELOG.md 🚀 performance Optimization, memory use, etc 🍏 primitives Relating to Rerun primitives 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants