happy clippy

rerun-io · Jan 22, 2025 · 16e36cd · 16e36cd
1 parent 2c3da52
commit 16e36cd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/crates/build/re_types_builder/src/codegen/rust/api.rs b/crates/build/re_types_builder/src/codegen/rust/api.rs
@@ -1959,12 +1959,16 @@ fn quote_builder_from_obj(reporter: &Reporter, objects: &Objects, obj: &Object)
         ");
         let columns_doc = quote_doc_lines(&columns_doc.lines().map(|l| l.to_owned()).collect_vec());
 
+        let has_indicator = obj.fqname.as_str() != "rerun.archetypes.Scalar";
+
+        let num_fields = required.iter().chain(optional.iter()).count();
         let fields = required.iter().chain(optional.iter()).map(|field| {
             let field_name = format_ident!("{}", field.name);
-            quote!(self.#field_name.map(|#field_name| #field_name.partitioned(_lengths.clone())).transpose()?)
+            let clone = if num_fields == 1 && !has_indicator { quote!(.into_iter()) } else { quote!(.clone()) };
+            quote!(self.#field_name.map(|#field_name| #field_name.partitioned(_lengths #clone)).transpose()?)
         });
 
-        let indicator_column = if obj.fqname.as_str() == "rerun.archetypes.Scalar" {
+        let indicator_column = if !has_indicator {
             // NOTE(#8768): Scalar indicators are extremely wasteful, and not actually used for anything.
             quote!(None)
         } else {

diff --git a/crates/store/re_types/src/archetypes/scalar.rs b/crates/store/re_types/src/archetypes/scalar.rs