-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tagged columnar updates work with mono-components too #8769
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
rerun::Scalar::update_fields() | ||
.with_many_scalar(scalars) | ||
.columns(std::iter::repeat(1).take(STEPS as _))? | ||
.filter(|column| !column.descriptor.component_name.contains("Indicator")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other languages do not log an indicator here, and for good reasons: indicators in a scalar chunk have huge overhead, and are completely useless as far as I can tell (i.e. they aren't needed for heuristics).
In a follow-up, I will introduce a hardcoded exception so that Scalar::columns
just doesn't generate it.
At least half of the generated code seems to be for blueprint archetypes. We don't need it, I'll add a hardcoded exception to ignore blueprint archetypes tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
We should be able to use this on the image_send_column
example. Can you have a look there as well?
@@ -1876,13 +1876,35 @@ fn quote_builder_from_obj(reporter: &Reporter, objects: &Objects, obj: &Object) | |||
} | |||
} | |||
} else { | |||
let quoted_many = obj.scope().is_none().then(|| { | |||
let method_name_many = format_ident!("with_many_{field_name}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with_many_scalar
is a bit bumpy 🤔
Can't come up with anything better either though. English's 's' pluralization is too imperfect and we don't want to change field names...
Well at least it stands out and the doc string then tells you what's up 👍
Ah? will do in the upcoming final clean up pass that removes all the legacy. |
See #8769 (review) for rationale: ![image](https://github.com/user-attachments/assets/1b017fb2-328c-46cd-8ead-4054c0ab5d0b) * Related: #8768 * Follow-up to #8753
send_columns
.scalar_send_columns
snippet to use new columnar APIs.