Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@react-router/dev): prevent argv parsing crash when optionnal args are passed to the cli #12609

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

PhilDL
Copy link
Contributor

@PhilDL PhilDL commented Dec 21, 2024

Related issue #12606
Introduced in release v7.1.0 with the changes required to have NODE_ENV correctly set-up for React 19.

In this file the optional args are not necessary but it shouldn't crash if present. The fixe handle that situation by not parsing positional args in this file.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 21, 2024

Hi @PhilDL,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

Copy link

changeset-bot bot commented Dec 21, 2024

⚠️ No Changeset found

Latest commit: 7e52fe1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 21, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr
Copy link
Member

timdorr commented Dec 21, 2024

Thank you!

@timdorr timdorr merged commit ae9a92d into remix-run:dev Dec 21, 2024
8 checks passed
@PhilDL PhilDL deleted the dev branch December 21, 2024 21:21
timdorr pushed a commit that referenced this pull request Dec 21, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 7.1.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants