-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added report of diagnostics for Cairo compiler #86
Conversation
Co-authored-by: Ara Adkins <[email protected]>
Co-authored-by: Ara Adkins <[email protected]>
1de3341
to
8c28e7e
Compare
50fefe0
to
99a0f26
Compare
99a0f26
to
716c80c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at first blush, but unless I'm missing something it doesn't seem to account for printing warnings. It should print both warnings and fatal errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Addition of error and warning description when Cairo projects fail to compile.
Details
In the situation in which not all of the Cairo files have compiled successfully, no
FlatLowered
is generated and all errors are reported.Checklist