Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added report of diagnostics for Cairo compiler #86

Merged
merged 17 commits into from
Nov 18, 2024

Conversation

Eagle941
Copy link
Contributor

@Eagle941 Eagle941 commented Nov 11, 2024

Summary

Addition of error and warning description when Cairo projects fail to compile.

Details

In the situation in which not all of the Cairo files have compiled successfully, no FlatLowered is generated and all errors are reported.

Checklist

  • Code is formatted by Rustfmt.
  • Documentation has been updated if necessary.

@Eagle941 Eagle941 force-pushed the wip/gafe/flat_lowered_export branch from 1de3341 to 8c28e7e Compare November 12, 2024 00:16
Base automatically changed from wip/gafe/flat_lowered_pipeline to main November 12, 2024 13:22
@Eagle941 Eagle941 force-pushed the wip/gafe/flat_lowered_export branch 3 times, most recently from 50fefe0 to 99a0f26 Compare November 12, 2024 14:05
@Eagle941 Eagle941 force-pushed the wip/gafe/flat_lowered_export branch from 99a0f26 to 716c80c Compare November 12, 2024 14:07
@Eagle941 Eagle941 marked this pull request as ready for review November 12, 2024 14:32
@Eagle941 Eagle941 requested a review from a team as a code owner November 12, 2024 14:32
Copy link
Collaborator

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first blush, but unless I'm missing something it doesn't seem to account for printing warnings. It should print both warnings and fatal errors.

Copy link
Collaborator

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Eagle941 Eagle941 merged commit 28e05e3 into main Nov 18, 2024
7 checks passed
@Eagle941 Eagle941 deleted the wip/gafe/flat_lowered_export branch November 18, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants