Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced FlatLowered with MultiLowered #90

Merged
merged 22 commits into from
Nov 18, 2024
Merged

Conversation

Eagle941
Copy link
Contributor

@Eagle941 Eagle941 commented Nov 16, 2024

Summary

This PR replaces FlatLowered with MultiLowered when calling the hieratika-cli build command.
It also adds exporting MultiLowered function to .lowered files.

The command hieratika-cli clean is added to delete all the .lowered files exported.

Details

The command build saves the exported .lowered files in target/cairo/flo/<crate_name>. This decision needs to be reviewed for execution of the build command outside of the project repo.

The build command overwrites existing files and it is not optimised to skip exporting of unchanged files.

This PR shall be merged after #86

Checklist

  • Code is formatted by Rustfmt.
  • Documentation has been updated if necessary.

@Eagle941 Eagle941 changed the title Wip/gafe/multi lowered Replaced FlatLowered with MultiLowered Nov 16, 2024
@Eagle941 Eagle941 force-pushed the wip/gafe/multi_lowered branch 2 times, most recently from 70e4958 to 1c72e08 Compare November 16, 2024 20:27
@Eagle941 Eagle941 force-pushed the wip/gafe/multi_lowered branch from 1c72e08 to b294bc4 Compare November 17, 2024 00:49
@Eagle941 Eagle941 force-pushed the wip/gafe/multi_lowered branch 2 times, most recently from 4d4149b to fd14f6a Compare November 17, 2024 18:23
@Eagle941 Eagle941 force-pushed the wip/gafe/multi_lowered branch from fd14f6a to 82c1eb7 Compare November 17, 2024 18:25
@Eagle941 Eagle941 marked this pull request as ready for review November 17, 2024 18:46
@Eagle941 Eagle941 requested a review from a team as a code owner November 17, 2024 18:46
Base automatically changed from wip/gafe/flat_lowered_export to main November 18, 2024 18:16
@Eagle941 Eagle941 force-pushed the wip/gafe/multi_lowered branch from cca5c54 to b3a43f0 Compare November 18, 2024 18:52
Copy link
Collaborator

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Eagle941 Eagle941 merged commit 96027c3 into main Nov 18, 2024
7 checks passed
@Eagle941 Eagle941 deleted the wip/gafe/multi_lowered branch November 18, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants