-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced FlatLowered
with MultiLowered
#90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ara Adkins <[email protected]>
Co-authored-by: Ara Adkins <[email protected]>
Eagle941
changed the title
Wip/gafe/multi lowered
Replaced Nov 16, 2024
FlatLowered
with MultiLowered
Eagle941
force-pushed
the
wip/gafe/multi_lowered
branch
2 times, most recently
from
November 16, 2024 20:27
70e4958
to
1c72e08
Compare
Eagle941
force-pushed
the
wip/gafe/multi_lowered
branch
from
November 17, 2024 00:49
1c72e08
to
b294bc4
Compare
Eagle941
force-pushed
the
wip/gafe/multi_lowered
branch
2 times, most recently
from
November 17, 2024 18:23
4d4149b
to
fd14f6a
Compare
Eagle941
force-pushed
the
wip/gafe/multi_lowered
branch
from
November 17, 2024 18:25
fd14f6a
to
82c1eb7
Compare
Eagle941
force-pushed
the
wip/gafe/multi_lowered
branch
from
November 18, 2024 18:52
cca5c54
to
b3a43f0
Compare
iamrecursion
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces
FlatLowered
withMultiLowered
when calling thehieratika-cli build
command.It also adds exporting
MultiLowered
function to.lowered
files.The command
hieratika-cli clean
is added to delete all the.lowered
files exported.Details
The command
build
saves the exported.lowered
files intarget/cairo/flo/<crate_name>
. This decision needs to be reviewed for execution of thebuild
command outside of the project repo.The
build
command overwrites existing files and it is not optimised to skip exporting of unchanged files.This PR shall be merged after #86
Checklist