Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend new Git Backend #2812

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Jun 26, 2024

This PR builds upon #2795 to extend the git backend and use it in even more places - and completely decouples the auto-tick command from the old git logic, allowing its local execution.

#2795 should be merged first. To easily compare what's new in this PR, click here.

This PR also adds some non-minor refactoring changes to the migration logic, which were more than needed to not make the existing state of the code even worse.

  • Pydantic model updated or no update needed

ytausch added a commit to ytausch/cf-scripts that referenced this pull request Jul 25, 2024
this does not do anything
see regro#2812 (comment)
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to break this one up into manageable chunks around 500 lines or so. The refactors of auto_tick.py especially need to be done bit by bit slowly since the testing of that code is non-existent.

@ytausch
Copy link
Contributor Author

ytausch commented Jul 25, 2024

I'll see what I can do, probably there will also more testing for auto_tick this time so things don't break

ytausch added a commit to ytausch/cf-scripts that referenced this pull request Jul 28, 2024
this does not do anything
see regro#2812 (comment)
ytausch added a commit to ytausch/cf-scripts that referenced this pull request Jul 28, 2024
ytausch added a commit to ytausch/cf-scripts that referenced this pull request Jul 28, 2024
@ytausch
Copy link
Contributor Author

ytausch commented Jul 28, 2024

The changes of this PR are split into different smaller PRs that are intended to be merged in their order below:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants