-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Git-4) Refactor rerender in auto_tick module #3000
Conversation
c7f3911
to
b472504
Compare
@beckermr pinging you as long as I cannot add you as a reviewer |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3000 +/- ##
==========================================
+ Coverage 76.16% 76.27% +0.11%
==========================================
Files 115 115
Lines 12476 12532 +56
==========================================
+ Hits 9502 9559 +57
+ Misses 2974 2973 -1 ☔ View full report in Codecov by Sentry. |
Sorry for the delay on write access! You should have permissions now! |
Thank you! |
74d37d8
to
0c37983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to look at the rest but I did notice one thing right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an inconsistent mix of passing arguments by keyword and in one case passing a keyword as an arg. Let's try and clean that up.
Co-authored-by: Matthew R. Becker <[email protected]>
Co-authored-by: Matthew R. Becker <[email protected]>
953f71a
to
ae89444
Compare
Description:
This PR continues the git-backend-related changes and refactors the auto_tick logic to reduce the complexity of the rerender code.
Note: This PR removes a
migrators
directory from a check for trivial rerender changes. We discussed this here: #2812 (comment).Since the broken check did not cause any issues, I did NOT add
.ci_support/migrations
instead.Checklist:
Cross-refs, links to issues, etc:
Please merge #2948 first.