Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Git-4) Refactor rerender in auto_tick module #3000

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Sep 7, 2024

Description:

This PR continues the git-backend-related changes and refactors the auto_tick logic to reduce the complexity of the rerender code.

Note: This PR removes a migrators directory from a check for trivial rerender changes. We discussed this here: #2812 (comment).

Since the broken check did not cause any issues, I did NOT add .ci_support/migrations instead.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

Please merge #2948 first.

@ytausch
Copy link
Contributor Author

ytausch commented Sep 7, 2024

@beckermr pinging you as long as I cannot add you as a reviewer

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 71.95122% with 23 lines in your changes missing coverage. Please review.

Project coverage is 76.27%. Comparing base (2600ca8) to head (ae89444).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/auto_tick.py 30.30% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3000      +/-   ##
==========================================
+ Coverage   76.16%   76.27%   +0.11%     
==========================================
  Files         115      115              
  Lines       12476    12532      +56     
==========================================
+ Hits         9502     9559      +57     
+ Misses       2974     2973       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beckermr
Copy link
Contributor

beckermr commented Sep 7, 2024

Sorry for the delay on write access! You should have permissions now!

@ytausch
Copy link
Contributor Author

ytausch commented Sep 7, 2024

Thank you!

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to look at the rest but I did notice one thing right away.

conda_forge_tick/auto_tick.py Outdated Show resolved Hide resolved
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an inconsistent mix of passing arguments by keyword and in one case passing a keyword as an arg. Let's try and clean that up.

conda_forge_tick/auto_tick.py Show resolved Hide resolved
conda_forge_tick/auto_tick.py Outdated Show resolved Hide resolved
conda_forge_tick/auto_tick.py Outdated Show resolved Hide resolved
@beckermr beckermr merged commit a1942f2 into regro:main Sep 16, 2024
7 of 8 checks passed
@ytausch ytausch deleted the continue-git-backend-part-4 branch September 16, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants