Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefetch pnc #44
base: rhoai-2.16
Are you sure you want to change the base?
Prefetch pnc #44
Changes from 2 commits
bbd536c
98effb5
cb3afa2
9b000dd
c1d3d5d
438236c
f4f7726
a578654
5ddd52e
72d320e
a11e920
7c3421e
50952fc
acfc092
f71f77a
f8e18d3
7acaf4a
b6920cd
a208165
5cd1517
b3f2a91
9a19d42
71649ca
13a3ed2
5f12236
49c3ce9
66f210c
8f0bc5c
f0e07b3
136e386
5a95ade
a2fd156
f6f9f77
7facec5
499f835
e07641a
152dab5
f49038f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you'd put in the files you need, these are just examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Could you please let me know which files you’re referring to here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those would be the files that you download from the internet during the build, which would violate the hermetic build condition. Having a brief look into your Dockerfile, I would say it's these files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be this one: https://github.com/red-hat-data-services/RHOAI-Build-Config/blob/rhoai-2.16/trustyai-pig-builds/build-config.yaml or https://gitlab.cee.redhat.com/project-ncl/utils.git as we have updated tekton file for PNC https://github.com/red-hat-data-services/trustyai-explainability/blob/rhoai-2.16/.tekton/odh-trustyai-service-v2-16-push.yaml#L284C4-L392C1