-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefetch pnc #44
base: rhoai-2.16
Are you sure you want to change the base?
Prefetch pnc #44
Conversation
@kosciCZ Could you please review the PR? |
generic_lockfile.yaml
Outdated
- download_url: https://github.com/cachito-testing/cachi2-generic/archive/refs/tags/v1.0.0.zip | ||
checksums: | ||
sha256: 4fbcaa2a8d17c1f8042578627c122361ab18b7973311e7e9c598696732902f87 | ||
- download_url: https://github.com/cachito-testing/cachi2-generic/archive/refs/tags/v2.0.0.zip | ||
target: archive.zip | ||
checksums: | ||
sha256: 386428a82f37345fa24b74068e0e79f4c1f2ff38d4f5c106ea14de4a2926e584 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you'd put in the files you need, these are just examples.
- download_url is the url the files is available from
- target is optional and specifies a subpath the file will be saved as. If not defined, it will be derived from the url
- checksums is a list of pairs of algorithm and hash, that is necessary to verify file identity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Could you please let me know which files you’re referring to here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those would be the files that you download from the internet during the build, which would violate the hermetic build condition. Having a brief look into your Dockerfile, I would say it's these files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be this one: https://github.com/red-hat-data-services/RHOAI-Build-Config/blob/rhoai-2.16/trustyai-pig-builds/build-config.yaml or https://gitlab.cee.redhat.com/project-ncl/utils.git as we have updated tekton file for PNC https://github.com/red-hat-data-services/trustyai-explainability/blob/rhoai-2.16/.tekton/odh-trustyai-service-v2-16-push.yaml#L284C4-L392C1
Co-authored-by: Jan Koscielniak <[email protected]>
Also, please also follow step 6 here to enable dev package managers (generic package fetcher still has just experimental support) |
Co-authored-by: Jan Koscielniak <[email protected]>
@kosciCZ I see this error during the pipeline run, any idea what could be added for generic fetcher to prefetch type |
@MohammadiIram that's gonna be the developer flag, see my other comment |
yeah, i will add the rpms.in.yaml, but for generic fetcher what can we add the type? |
@kosciCZ Ay idea why do we need ["./fedora.repo"] we would want upi.repo Something like this will be the rpms.in.yaml
|
@kosciCZ Could we merge this PR and look what we find in the pipeline run? |
You can specify a json array like this: [{"path": ".", "type": "rpm"}, {"path": ".", "type": "generic"}] |
yeah, but that is not supported i guess we hit this error
|
It should be supported now that you added the "dev-package-managers" flag |
Added, but still i see same error https://github.com/red-hat-data-services/trustyai-explainability/pull/44/checks?check_run_id=32322784387 |
It is possible that the prefetch task is fixed to the previous version of cachi2. Could you please try updating the reference from
to
|
Also, you should update the Dockerfile to remove the ARG PNC_FILES_JSON and you don't need the |
After updating i see this Task Statuses: |
@kosciCZ I also tried to update it with the latest digest which is sha256:3be04adda63fc843db5eea837cabe33317a6d4f378c559de0c7ef888103e7fd4 Error: InvalidInput: 1 validation error for user input |
Co-authored-by: Jan Koscielniak <[email protected]>
No description provided.