-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] hadolint warnings to base and rstudio Dockerfiles #331
[fix] hadolint warnings to base and rstudio Dockerfiles #331
Conversation
/lgtm |
/retest |
1 similar comment
/retest |
Won't help,
on 2023b never succeeds |
I must have overlooked the anaconda failure before then, now I see it. |
/override ci/prow/images anaconda image fails to build, known issue |
@jiridanek: jiridanek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Just realized that we have an upstream -> downstream branch regular updates. So maybe this is irrelevant and I should just check that the appropriate changes are done in a relevant branch in upstream, right? I'm moving this to draft until it's clear. |
These changes shouldn't have any functional impact. (cherry picked from commit a674246)
a39271a
to
1d8c6ae
Compare
Hehe, the files that are changed in this PR aren't upstream, so we can't rely on upstream->downstream sync in these cases. Undrafted, ready for refiew/merge. |
/lgtm |
@jstourac: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@harshad16 do you mind to give your review/opinion so we can merge this eventually? |
Could you please share why this is being pointed to the 2023b release branch? (i might seem have forgotten 🙈 ) |
Reason of this is the idea of backporting some CI checks to the 2023b branch as created in #330. Before the merge of that PR, I thought to have this merged separately first so that it is a reasonable small change and visible enough. Another approach would be to put these hadolint warnings into the ignore and ditch this PR completely now. |
The Jira (and comment https://issues.redhat.com/browse/RHOAIENG-7884?focusedId=24934565&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-24934565 in it) is about putting the CI check (and necessary fixes to make the check pass) into all relevant branches. I'd put this in. |
Thank you for the response, lgtm. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
89044ee
into
red-hat-data-services:release-2023b
These changes shouldn't have any functional impact.
(cherry picked from commit a674246)
This is backport of #179; tracked in https://issues.redhat.com/browse/RHOAIENG-7884