Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] hadolint warnings to base and rstudio Dockerfiles #331

Merged

Conversation

jstourac
Copy link
Member

These changes shouldn't have any functional impact.

(cherry picked from commit a674246)

This is backport of #179; tracked in https://issues.redhat.com/browse/RHOAIENG-7884

@jiridanek
Copy link
Member

/lgtm

@jiridanek
Copy link
Member

/retest

1 similar comment
@jstourac
Copy link
Member Author

/retest

@jiridanek
Copy link
Member

/retest

Won't help,

: Build image jupyter-datascience-anaconda-python-3.8 from the repository expand_more

on 2023b never succeeds

@jstourac
Copy link
Member Author

: Build image jupyter-datascience-anaconda-python-3.8 from the repository expand_more

on 2023b never succeeds

I must have overlooked the anaconda failure before then, now I see it.

@jiridanek
Copy link
Member

/override ci/prow/images

anaconda image fails to build, known issue

Copy link

openshift-ci bot commented Jul 19, 2024

@jiridanek: jiridanek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override ci/prow/images

anaconda image fails to build, known issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstourac
Copy link
Member Author

Just realized that we have an upstream -> downstream branch regular updates. So maybe this is irrelevant and I should just check that the appropriate changes are done in a relevant branch in upstream, right? I'm moving this to draft until it's clear.

@jstourac jstourac marked this pull request as draft July 19, 2024 12:37
These changes shouldn't have any functional impact.

(cherry picked from commit a674246)
@openshift-ci openshift-ci bot removed the lgtm label Aug 12, 2024
@jstourac jstourac marked this pull request as ready for review August 12, 2024 16:44
@openshift-ci openshift-ci bot requested review from caponetto and paulovmr August 12, 2024 16:45
@jstourac
Copy link
Member Author

Just realized that we have an upstream -> downstream branch regular updates. So maybe this is irrelevant and I should just check that the appropriate changes are done in a relevant branch in upstream, right? I'm moving this to draft until it's clear.

Hehe, the files that are changed in this PR aren't upstream, so we can't rely on upstream->downstream sync in these cases. Undrafted, ready for refiew/merge.

@jiridanek
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 12, 2024
Copy link

openshift-ci bot commented Aug 12, 2024

@jstourac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 1d8c6ae link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jstourac
Copy link
Member Author

@harshad16 do you mind to give your review/opinion so we can merge this eventually?

@harshad16
Copy link
Member

do you mind to give your review/opinion so we can merge this eventually?

Could you please share why this is being pointed to the 2023b release branch? (i might seem have forgotten 🙈 )
Till i remember, we are providing only build configs with on imagestream pointing to latest tag, so i m unable to recollect why we are targeting 2023b branch.

@jstourac
Copy link
Member Author

Could you please share why this is being pointed to the 2023b release branch? (i might seem have forgotten 🙈 ) Till i remember, we are providing only build configs with on imagestream pointing to latest tag, so i m unable to recollect why we are targeting 2023b branch.

Reason of this is the idea of backporting some CI checks to the 2023b branch as created in #330. Before the merge of that PR, I thought to have this merged separately first so that it is a reasonable small change and visible enough.

Another approach would be to put these hadolint warnings into the ignore and ditch this PR completely now.

@jiridanek
Copy link
Member

jiridanek commented Aug 28, 2024

The Jira (and comment https://issues.redhat.com/browse/RHOAIENG-7884?focusedId=24934565&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-24934565 in it) is about putting the CI check (and necessary fixes to make the check pass) into all relevant branches. I'd put this in.

@harshad16
Copy link
Member

Thank you for the response, lgtm.
/lgtm
/approve

Copy link

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit 89044ee into red-hat-data-services:release-2023b Aug 28, 2024
2 of 4 checks passed
@jstourac jstourac deleted the downHadolint2023b branch August 29, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants