Skip to content

Commit

Permalink
Merge pull request #331 from jstourac/downHadolint2023b
Browse files Browse the repository at this point in the history
[fix] hadolint warnings to base and rstudio Dockerfiles
  • Loading branch information
harshad16 authored Aug 28, 2024
2 parents 772a772 + 1d8c6ae commit 89044ee
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions base/rhel9-python-3.9/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ LABEL name="rhoai-notebook-base-rhel9-python-3.9" \
WORKDIR /opt/app-root/bin

# Install micropipenv to deploy packages from Pipfile.lock
RUN pip install -U "micropipenv[toml]"
RUN pip install --no-cache-dir -U "micropipenv[toml]"

# Install Python dependencies from Pipfile.lock file

Expand All @@ -24,7 +24,7 @@ RUN echo "Installing softwares and packages" && micropipenv install && rm -f ./P
USER root

# Install usefull OS packages
RUN dnf install -y mesa-libGL
RUN dnf install -y mesa-libGL && dnf clean all && rm -rf /var/cache/yum

# Other apps and tools installed as default user
USER 1001
Expand Down
7 changes: 4 additions & 3 deletions rstudio/rhel9-python-3.9/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ ENV R_LIBS_USER /opt/app-root/src/Rpackages/4.3
WORKDIR /tmp/

# Install RStudio
RUN wget https://download2.rstudio.org/server/rhel9/x86_64/rstudio-server-rhel-2023.06.1-524-x86_64.rpm && \
RUN wget --progress=dot:giga https://download2.rstudio.org/server/rhel9/x86_64/rstudio-server-rhel-2023.06.1-524-x86_64.rpm && \
yum install -y rstudio-server-rhel-2023.06.1-524-x86_64.rpm && \
rm rstudio-server-rhel-2023.06.1-524-x86_64.rpm && \
yum -y clean all --enablerepo='*'
Expand All @@ -69,7 +69,8 @@ RUN chmod 1777 /var/run/rstudio-server && \
COPY rstudio/rhel9-python-3.9/rsession.conf /etc/rstudio/rsession.conf

# package installation
RUN dnf install -y libsodium-devel.x86_64 libgit2-devel.x86_64 libcurl-devel harfbuzz-devel.x86_64 fribidi-devel.x86_64 cmake "flexiblas-*"
RUN dnf install -y libsodium-devel.x86_64 libgit2-devel.x86_64 libcurl-devel harfbuzz-devel.x86_64 fribidi-devel.x86_64 cmake "flexiblas-*" && \
dnf clean all && rm -rf /var/cache/yum
RUN R -e "install.packages('Rcpp')"

# Install NGINX to proxy RStudio and pass probes check
Expand Down Expand Up @@ -142,4 +143,4 @@ WORKDIR /opt/app-root/src

USER 1001

CMD /opt/app-root/bin/run-rstudio.sh
CMD ["/opt/app-root/bin/run-rstudio.sh"]

0 comments on commit 89044ee

Please sign in to comment.