Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Module certification issues #231

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

fix: Module certification issues #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2d95cfb
Module execution Certification issues
anjalimukundan Oct 10, 2024
49f5488
addressed review comment
anjalimukundan Oct 11, 2024
8d94326
updated event validation logs
anjalimukundan Oct 11, 2024
0cd31fb
updated eventId logs
anjalimukundan Oct 14, 2024
cb4eb2a
fixed lifecycle history validation logs
anjalimukundan Oct 14, 2024
f28b2e1
updated firelog for lifecycle validation
anjalimukundan Oct 15, 2024
c075ef3
review comments
Oct 18, 2024
9a86233
review comments address
Oct 21, 2024
1ed1346
fixed lint issues
anjalimukundan Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cypress/TestCases/FireboltCertification/Advertising.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ Feature: Advertising
@sdk @transport
Scenario Outline: Advertising.advertisingId - Positive Scenario: <Scenario>
When 1st party app invokes the 'Firebolt' API to '<MANAGE_API_Key>'
And '3rd party app' invokes the 'Firebolt' API to '<CORE_API_Key>'
Then 'Firebolt' platform responds to '1st party app' with '<MANAGE_API_Key>'
When '3rd party app' invokes the 'Firebolt' API to '<CORE_API_Key>'
Then 'Firebolt' platform responds with '<Validation_key>'
Expand Down
2 changes: 1 addition & 1 deletion cypress/TestCases/FireboltCertification/Localization.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Feature: Localization
| Set & get Language en | language | en |
| Set & get preferredAudioLanguages(spa-eng) | preferredAudioLanguages | spa,eng |
| Set & get preferredAudioLanguages(eng-spa) | preferredAudioLanguages | eng,spa |
| Set & get PostalCode | postalCode | 12345 |
| Set & get PostalCode | postalCode | "12345" |

@regression @sdk @requiresPlatformImplementation
Scenario Outline: Localization.<Method_Name> - Positive Scenario: Clearing event listeners
Expand Down
2 changes: 1 addition & 1 deletion cypress/TestCases/FireboltCertification/Manage/AdvertisingManage.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Feature: Advertising_Manage
Scenario: Advertising.setSkipRestriction - Negative Scenario: SkipRestriction expecting error
Given we test the 'ADVERTISING_SKIP_RESTRICTION' getters and setters 'skipRestriction' to '898756'
When 1st party app invokes the 'Firebolt' API to set invalid value
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_TYPE_PARAMS'
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_PARAMS'

@sdk @transport @notSupported
Scenario: Advertising.resetIdentifier - Positive Scenario: Reset Identifier method
Expand Down
2 changes: 1 addition & 1 deletion cypress/TestCases/FireboltCertification/Manage/AudioDescriptionsManage.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Feature: AudioDescriptions_Manage
Scenario Outline: AudioDescriptions.enabled - Negative Scenario: <Scenario> expecting error
Given we test the 'AUDIODESCRIPTIONS' getters and setters 'enabled' to '<Value>'
When 1st party app invokes the 'Firebolt' API to set invalid value
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_TYPE_PARAMS'
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_PARAMS'

Examples:
| Scenario | Value |
Expand Down
70 changes: 35 additions & 35 deletions cypress/TestCases/FireboltCertification/Manage/ClosedCaptionsManage.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,40 +78,40 @@ Feature: ClosedCaptions_Manage
Scenario Outline: ClosedCaptions.<Method> - Negative Scenario: <Scenario> expecting error
Given we test the 'CLOSED_CAPTIONS_SETTINGS' getters and setters '<Method>' to '<Value>'
When 1st party app invokes the 'Firebolt' API to set invalid value
Then 'Firebolt' platform responds to '1st party app' set API with '<Error>'
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_PARAMS'

Examples:
| Scenario | Method | Value | Error |
| Set enabled-test | enabled | test | INVALID_TYPE_PARAMS |
| Set enabled-123 | enabled | 123 | INVALID_TYPE_PARAMS |
| Set fontFamily-123 | fontFamily | 123 | INVALID_TYPE_PARAMS |
| Set fontFamily-true | fontFamily | true | INVALID_TYPE_PARAMS |
| Set fontSize-true | fontSize | true | INVALID_TYPE_PARAMS |
| Set fontSize-test | fontSize | test | INVALID_TYPE_PARAMS |
| Set fontSize-true | fontSize | true | INVALID_TYPE_PARAMS |
| Set fontSize-0.25 | fontSize | 0.25 | INVALID_TYPE_PARAMS |
| Set fontFamily-sans-serif | fontFamily | sans-serif | INVALID_TYPE_PARAMS |
| Set fontEdge-123 | fontEdge | 123 | INVALID_TYPE_PARAMS |
| Set fontEdge-true | fontEdge | true | INVALID_TYPE_PARAMS |
| Set fontEdge-solid | fontEdge | solid | INVALID_TYPE_PARAMS |
| Set preferredLanguages-true | preferredLanguages | true | INVALID_TYPE_PARAMS |
| Set preferredLanguages-123 | preferredLanguages | 123 | INVALID_TYPE_PARAMS |
| Set preferredLanguages-test | preferredLanguages | test | INVALID_TYPE_PARAMS |
| Set windowColor-123 | windowColor | 123 | INVALID_TYPE_PARAMS |
| Set windowOpacity-true | windowOpacity | true | INVALID_TYPE_PARAMS |
| Set fontEdgeColor-123 | fontEdgeColor | 123 | INVALID_TYPE_PARAMS |
| Set fontEdgeColor-true | fontEdgeColor | true | INVALID_TYPE_PARAMS |
| Set backgroundColor-123 | backgroundColor | 123 | INVALID_TYPE_PARAMS |
| Set backgroundColor-true | backgroundColor | true | INVALID_TYPE_PARAMS |
| Set textAlign-123 | textAlign | 123 | INVALID_TYPE_PARAMS |
| Set textAlign-true | textAlign | true | INVALID_TYPE_PARAMS |
| Set textAlignVertical-123 | textAlignVertical | 123 | INVALID_TYPE_PARAMS |
| Set textAlignVertical-true | textAlignVertical | true | INVALID_TYPE_PARAMS |
| Set fontColor-123 | fontColor | 123 | INVALID_TYPE_PARAMS |
| Set fontColor-true | fontColor | true | INVALID_TYPE_PARAMS |
| Set fontOpacity-120 | fontOpacity | 120 | INVALID_TYPE_PARAMS |
| Set fontOpacity-test | fontOpacity | test | INVALID_TYPE_PARAMS |
| Set fontOpacity-true | fontOpacity | true | INVALID_TYPE_PARAMS |
| Set backgroundOpacity-120 | backgroundOpacity | 120 | INVALID_TYPE_PARAMS |
| Set backgroundOpacity-test | backgroundOpacity | test | INVALID_TYPE_PARAMS |
| Set backgroundOpacity-true | backgroundOpacity | true | INVALID_TYPE_PARAMS |
| Scenario | Method | Value |
| Set enabled-test | enabled | test |
| Set enabled-123 | enabled | 123 |
| Set fontFamily-123 | fontFamily | 123 |
| Set fontFamily-true | fontFamily | true |
| Set fontSize-true | fontSize | true |
| Set fontSize-test | fontSize | test |
| Set fontSize-true | fontSize | true |
| Set fontSize-0.25 | fontSize | 0.25 |
| Set fontFamily-sans-serif | fontFamily | sans-serif |
| Set fontEdge-123 | fontEdge | 123 |
| Set fontEdge-true | fontEdge | true |
| Set fontEdge-solid | fontEdge | solid |
| Set preferredLanguages-true | preferredLanguages | true |
| Set preferredLanguages-123 | preferredLanguages | 123 |
| Set preferredLanguages-test | preferredLanguages | test |
| Set windowColor-123 | windowColor | 123 |
| Set windowOpacity-true | windowOpacity | true |
| Set fontEdgeColor-123 | fontEdgeColor | 123 |
| Set fontEdgeColor-true | fontEdgeColor | true |
| Set backgroundColor-123 | backgroundColor | 123 |
| Set backgroundColor-true | backgroundColor | true |
| Set textAlign-123 | textAlign | 123 |
| Set textAlign-true | textAlign | true |
| Set textAlignVertical-123 | textAlignVertical | 123 |
| Set textAlignVertical-true | textAlignVertical | true |
| Set fontColor-123 | fontColor | 123 |
| Set fontColor-true | fontColor | true |
| Set fontOpacity-120 | fontOpacity | 120 |
| Set fontOpacity-test | fontOpacity | test |
| Set fontOpacity-true | fontOpacity | true |
| Set backgroundOpacity-120 | backgroundOpacity | 120 |
| Set backgroundOpacity-test | backgroundOpacity | test |
| Set backgroundOpacity-true | backgroundOpacity | true |
2 changes: 1 addition & 1 deletion cypress/TestCases/FireboltCertification/Manage/DeviceManage.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Feature: Device_Manage
Scenario Outline: Device.name - Negative Scenario: <Scenario> expecting error
Given we test the 'DEVICE_NAME' getters and setters 'setName' to '<Value>'
When 1st party app invokes the 'Firebolt' API to set invalid value
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_TYPE_PARAMS'
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_PARAMS'

Examples:
| Scenario | Value |
Expand Down
8 changes: 4 additions & 4 deletions cypress/TestCases/FireboltCertification/Manage/LocalizationManage.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Feature: Localization_Manage
Examples:
| Scenario | Method | Value |
| Locality | locality | washington |
| PostalCode | postalCode | 123456 |
| PostalCode | postalCode | "123456" |
| CountryCode | countryCode | PH |
| Language es | language | es |
| Language en | language | en |
Expand All @@ -30,7 +30,7 @@ Feature: Localization_Manage
Scenario Outline: Localization.<Method> - Negative Scenario: <Scenario> expecting error
Given we test the 'LOCALIZATION_MANAGE' getters and setters '<Method>' to '<Value>'
When 1st party app invokes the 'Firebolt' API to set invalid value
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_TYPE_PARAMS'
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_PARAMS'

Examples:
| Scenario | Method | Value |
Expand All @@ -46,7 +46,7 @@ Feature: Localization_Manage
Scenario Outline: Localization.<Method> - Negative Scenario: <Scenario> expecting error
Given we test the 'LOCALIZATION_MANAGE' getters and setters '<Method>' to '<Value>'
When 1st party app invokes the 'Firebolt' API to set invalid value
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_TYPE_PARAMS'
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_PARAMS'

Examples:
| Scenario | Method | Value |
Expand All @@ -62,7 +62,7 @@ Feature: Localization_Manage
Scenario Outline: Localization.removeAdditionalInfo - Negative Scenario: <Scenario> and expecting error
Given we test the 'LOCALIZATION_ADDITIONAL_INFO' getters and setters '<Method>' to '<Value>'
When 1st party app invokes the 'Firebolt' API to set invalid value
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_TYPE_PARAMS'
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_PARAMS'

Examples:
| Scenario | Method | Value |
Expand Down
2 changes: 1 addition & 1 deletion cypress/TestCases/FireboltCertification/Manage/PrivacyManage.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Feature: Privacy_Manage
Scenario Outline: Privacy.<Method> - Negative Scenario: <Scenario> and expecting error
Given we test the 'PRIVACY_SETTINGS' getters and setters '<Method>' to '<Value>'
When 1st party app invokes the 'Firebolt' API to set invalid value
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_TYPE_PARAMS'
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_PARAMS'

Examples:
| Scenario | Method | Value |
Expand Down
2 changes: 1 addition & 1 deletion cypress/TestCases/FireboltCertification/Manage/VoiceGuidanceManage.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Feature: VoiceGuidance_Manage
Scenario Outline: Voiceguidance.<Method> - Negative Scenario: <Scenario> and expecting error
Given we test the 'VOICEGUIDANCE' getters and setters '<Method>' to '<Value>'
When 1st party app invokes the 'Firebolt' API to set invalid value
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_TYPE_PARAMS'
Then 'Firebolt' platform responds to '1st party app' set API with 'INVALID_PARAMS'

Examples:
| Scenario | Method | Value |
Expand Down
2 changes: 1 addition & 1 deletion cypress/fixtures/docs/dynamicObjects.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ In the below testcase, fetching the firebolt object `CLOSED_CAPTIONS_SETTINGS` a

Examples:
| Scenario | Method | Value | Error |
| Set enabled-test | enabled | test | INVALID_TYPE_PARAMS |
| Set enabled-test | enabled | test | INVALID_PARAMS |
```

## Advanced Support
Expand Down
4 changes: 2 additions & 2 deletions cypress/fixtures/docs/validations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ Below is the default error objects supported in FCS [errorContentObjects.json](.
- NOT_SUPPORTED - This can be used for api's which are not supported
- NOT_PERMITTED - This can be used for api's which are not supported
- NOT_AVAILABLE - This can be used for api's which are not supported
- INVALID_TYPE_PARAMS - This can be used for error validation which involves calling firebolt methods with invalid parameters, missing parameters etc.
- INVALID_PARAMS - This can be used for error validation which involves calling firebolt methods with invalid parameters, missing parameters etc.

#### Format

Expand Down Expand Up @@ -547,7 +547,7 @@ Note: FCS expects the error object to be defined in the above format. Any deviat
##### Example:

```
"INVALID_TYPE_PARAMS": {
"INVALID_PARAMS": {
"type": "errorValidationFunction",
"validations": [
{
Expand Down
4 changes: 2 additions & 2 deletions cypress/fixtures/fireboltCalls/accessibility.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,13 +1043,13 @@
"INVALID_REQUEST_FOR_CLOSEDCAPTIONS_SETTINGS": {
"method": "accessibility.closedCaptionsSettings",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS",
"content": "INVALID_PARAMS",
"expectingError": true
},
"INVALID_REQUEST_FOR_VOICEGUIDANCE_SETTINGS": {
"method": "accessibility.voiceGuidanceSettings",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS",
"content": "INVALID_PARAMS",
"expectingError": true
},
"GET_CLOSEDCAPTIONS":{
Expand Down
6 changes: 3 additions & 3 deletions cypress/fixtures/fireboltCalls/account.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,14 @@ exports.FETCH_ACCOUNT_UID_WHEN_DEVICE_IS_NOT_PROVISIONED = {
exports.INVALID_PARAMETER_ERROR_FOR_ACCOUNT_ID = {
method: 'account.id',
validationJsonPath: 'result',
content: errorContent.INVALID_TYPE_PARAMS,
content: errorContent.INVALID_PARAMS,
expectingError: true,
};

exports.INVALID_PARAMETER_ERROR_FOR_ACCOUNT_UID = {
method: 'account.uid',
validationJsonPath: 'result',
content: errorContent.INVALID_TYPE_PARAMS,
content: errorContent.INVALID_PARAMS,
expectingError: true,
};

Expand Down Expand Up @@ -138,6 +138,6 @@ exports.SET_ACCOUNT_SESSION_WITHOUT_PARAMETERS = {
exports.INVALID_PARAMETERS_FOR_ACCOUNT_SESSION = {
method: 'manage_account.session',
validationJsonPath: 'result',
content: errorContent.INVALID_TYPE_PARAMS,
content: errorContent.INVALID_PARAMS,
expectingError: true,
};
8 changes: 4 additions & 4 deletions cypress/fixtures/fireboltCalls/account.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
"INVALID_PARAMETER_ERROR_FOR_ACCOUNT_ID": {
"method": "account.id",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS"
"content": "INVALID_PARAMS"
},
"INVALID_PARAMETER_ERROR_FOR_ACCOUNT_UID": {
"method": "account.uid",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS"
"content": "INVALID_PARAMS"
},
"INVALID_REQUEST_ERROR_FOR_ACCOUNT_UID": {
"method": "account.uid",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS",
"content": "INVALID_PARAMS",
"expectingError": true
},
"PUSH_SESSION_TOKEN": {
Expand All @@ -52,7 +52,7 @@
"INVALID_PARAMETERS_FOR_ACCOUNT_SESSION": {
"method": "account.session",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS",
"content": "INVALID_PARAMS",
"expectingError": true
},
"SET_ACCOUNT_SESSION_WITH_INVALID_EXPIRESIN": {
Expand Down
4 changes: 2 additions & 2 deletions cypress/fixtures/fireboltCalls/advertising.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,14 +366,14 @@ exports.GET_ADVERTISINGID_WITH_INVALID_ID = {
exports.INVALID_PARAMETER_FOR_ADVERTISING_ADVERTISINGID = {
method: 'advertising.advertisingId',
validationJsonPath: 'result',
content: errorContent.INVALID_TYPE_PARAMS,
content: errorContent.INVALID_PARAMS,
expectingError: true,
};

exports.INVALID_PARAMETER_ERROR_ADVERTISING_CONFIG = {
method: 'advertising.config',
validationJsonPath: 'result',
content: errorContent.INVALID_TYPE_PARAMS,
content: errorContent.INVALID_PARAMS,
expectingError: true,
};

Expand Down
8 changes: 4 additions & 4 deletions cypress/fixtures/fireboltCalls/advertising.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@
"INVALID_PARAMETER_ERROR_ADVERTISING_CONFIG": {
"method": "advertising.config",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS",
"content": "INVALID_PARAMS",
"expectingError": true
},
"ADVERTISING_SKIPRESTRICTION": {
Expand All @@ -217,7 +217,7 @@
"INVALID_PARAMETER_FOR_ADVERTISING_ADVERTISINGID": {
"method": "advertising.advertisingId",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS",
"content": "INVALID_PARAMS",
"expectingError": true
},
"ADVERTISING_CONFIG": {
Expand Down Expand Up @@ -297,7 +297,7 @@
"INVALID_PARAMETERS_FOR_SKIPRESTRICTION": {
"method": "advertising.setSkipRestriction",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS",
"content": "INVALID_PARAMS",
"expectingError": true
},
"GET_ADVERTISINGID_WITHOUT_SCOPE": {
Expand Down Expand Up @@ -353,7 +353,7 @@
"INVALID_REQUEST_FOR_ADVERTISING_POLICY": {
"method": "advertising.policy",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS",
"content": "INVALID_PARAMS",
"expectingError": true
}
}
2 changes: 1 addition & 1 deletion cypress/fixtures/fireboltCalls/audiodescriptions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"INVALID_PARAMS_FOR_AUDIODESCRIPTIONS_SETENABLED": {
"method": "audiodescriptions.setEnabled",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS",
"content": "INVALID_PARAMS",
"expectingError": true
},
"AUDIODESCRIPTIONS_ONENABLEDCHANGED":{
Expand Down
2 changes: 1 addition & 1 deletion cypress/fixtures/fireboltCalls/authentication.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,6 @@ exports.GET_TOKEN_WITH_INTEGER_PARAMETER = {
exports.INVALID_PARAMETER_ERROR_AUTHENTICATION_TOKEN = {
method: 'authentication.token',
validationJsonPath: 'result',
content: errorContent.INVALID_TYPE_PARAMS,
content: errorContent.INVALID_PARAMS,
expectingError: true,
};
4 changes: 2 additions & 2 deletions cypress/fixtures/fireboltCalls/authentication.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"INVALID_PARAMETER_ERROR_AUTHENTICATION_TOKEN": {
"method": "authentication.token",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS",
"content": "INVALID_PARAMS",
"expectingError": true
},
"EXPECT_ERROR_FOR_DEVICE_TOKEN": {
Expand All @@ -81,7 +81,7 @@
"INVALID_REQUEST_FOR_AUTHENTICATION_DEVICE": {
"method": "authentication.device",
"validationJsonPath": "result",
"content": "INVALID_TYPE_PARAMS",
"content": "INVALID_PARAMS",
"expectingError": true
}
}
Loading
Loading