fix: Module certification issues #231

anjalimukundan · 2024-10-10T15:42:22Z

No description provided.

CLAassistant · 2024-10-10T15:42:33Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ anjalimukundan
❌ Ibrahim S

Ibrahim S seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

github-actions · 2024-10-10T15:51:26Z

Invalid PR title. It must start with feat: or fix: or BREAKING CHANGE: or feat(): or fix(): or BREAKING CHANGE():. Please see our Contributing-Guide.

neeradanelxsi · 2024-10-10T15:52:00Z

Closing PR as it was created against main branch of FCS

cypress/support/cypress-commands/lifecycle.js

github-actions · 2024-10-18T10:16:38Z

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/fixtures/fireboltCalls/discovery.js
  693:25  error  Parsing error: Unexpected token ,

✖ 1 problem (1 error, 0 warnings)

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

github-actions · 2024-10-18T10:16:49Z

Build error occurred while running sample test with the following errors:

Error: Build failed with 1 error:
cypress/fixtures/fireboltCalls/discovery.js:693:24: ERROR: Expected identifier but found ","
    at failureErrorWithLog (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1636:15)
    at /home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1048:25
    at runOnEndCallbacks (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1471:45)
    at buildResponseToResult (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1046:7)

For more information on our testing policies, please see our Testing-Guide.

neeradanelxsi · 2024-10-18T12:58:48Z

cypress/fixtures/objects/errorContentObjects.json

@@ -10,5 +10,9 @@
    },
    "INVALID_TYPE_PARAMS": {
        "type": "schemaOnly"


you can remove INVALID_TYPE_PARAMS

review comment addresed

jmeier204 · 2024-10-18T13:33:41Z

cypress/TestCases/FireboltCertification/Advertising.feature

      Then 'Firebolt' platform responds to '1st party app' with '<MANAGE_API_Key>'
-      When '3rd party app' invokes the 'Firebolt' API to '<CORE_API_Key>'
+      And '3rd party app' invokes the 'Firebolt' API to '<CORE_API_Key>'


This should be 'When' keyword. Do. not understand why it was changed to 'And'

review comment addresed

jmeier204 · 2024-10-18T13:34:59Z

cypress/fixtures/objects/errorContentObjects.js

@@ -27,3 +27,6 @@ exports.NOT_AVAILABLE = {
 exports.INVALID_TYPE_PARAMS = {


If we removed 'INVALID_TYPE_PARAMS' We can probably remove this Export Also.

review comment addresed

neeradanelxsi · 2024-10-18T15:06:14Z

cypress/TestCases/FireboltCertification/Manage/ClosedCaptionsManage.feature

+            | Set fontOpacity-test        | fontOpacity        | test       | INVALID_PARAMS |
+            | Set fontOpacity-true        | fontOpacity        | true       | INVALID_PARAMS |
+            | Set backgroundOpacity-120   | backgroundOpacity  | 120        | INVALID_PARAMS |
+            | Set backgroundOpacity-test  | backgroundOpacity  | test       | INVALID_PARAMS |


if all of the values are same, why do we need a separate column here

review comment addresed

github-actions · 2024-10-21T08:52:27Z

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/fixtures/fireboltCalls/discovery.js
  693:25  error  Parsing error: Unexpected token ,

✖ 1 problem (1 error, 0 warnings)

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

github-actions · 2024-10-21T08:52:51Z

Build error occurred while running sample test with the following errors:

Error: Build failed with 1 error:
cypress/fixtures/fireboltCalls/discovery.js:693:24: ERROR: Expected identifier but found ","
    at failureErrorWithLog (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1636:15)
    at /home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1048:25
    at runOnEndCallbacks (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1471:45)
    at buildResponseToResult (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1046:7)

For more information on our testing policies, please see our Testing-Guide.

Module execution Certification issues

2d95cfb

anjalimukundan changed the base branch from main to dev October 10, 2024 15:51

neeradanelxsi closed this Oct 10, 2024

anjalimukundan reopened this Oct 10, 2024

anjalimukundan changed the title ~~Module certification issues~~ fix: Module certification issues Oct 10, 2024

neeradanelxsi reviewed Oct 10, 2024

View reviewed changes

cypress/support/cypress-commands/lifecycle.js Show resolved Hide resolved

anjalimukundan added 5 commits October 11, 2024 10:59

addressed review comment

49f5488

updated event validation logs

8d94326

updated eventId logs

0cd31fb

fixed lifecycle history validation logs

cb4eb2a

updated firelog for lifecycle validation

f28b2e1

neeradanelxsi previously approved these changes Oct 15, 2024

View reviewed changes

jbigel previously approved these changes Oct 17, 2024

View reviewed changes

review comments

c075ef3

ibrahimshuail dismissed stale reviews from jbigel and neeradanelxsi via c075ef3 October 18, 2024 10:15

neeradanelxsi reviewed Oct 18, 2024

View reviewed changes

jmeier204 requested changes Oct 18, 2024

View reviewed changes

neeradanelxsi reviewed Oct 18, 2024

View reviewed changes

review comments address

9a86233

fixed lint issues

1ed1346

jmeier204 approved these changes Oct 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Module certification issues #231

fix: Module certification issues #231

anjalimukundan commented Oct 10, 2024

CLAassistant commented Oct 10, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024

neeradanelxsi commented Oct 10, 2024

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

neeradanelxsi Oct 18, 2024

ibrahimshuail Oct 21, 2024

jmeier204 Oct 18, 2024

ibrahimshuail Oct 21, 2024

jmeier204 Oct 18, 2024

ibrahimshuail Oct 21, 2024

neeradanelxsi Oct 18, 2024

ibrahimshuail Oct 21, 2024

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

		@@ -27,3 +27,6 @@ exports.NOT_AVAILABLE = {
		exports.INVALID_TYPE_PARAMS = {

fix: Module certification issues #231

Are you sure you want to change the base?

fix: Module certification issues #231

Conversation

anjalimukundan commented Oct 10, 2024

CLAassistant commented Oct 10, 2024 • edited Loading

github-actions bot commented Oct 10, 2024

neeradanelxsi commented Oct 10, 2024

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

CLAassistant commented Oct 10, 2024 •

edited

Loading