Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init variables, check for valid file pointers before using, provide valid return values #1424

Open
wants to merge 19 commits into
base: production
Choose a base branch
from

Conversation

lazydroid
Copy link
Collaborator

@lazydroid lazydroid commented Sep 6, 2024

This MR fixes minor issues in the using uninitialized variables, returning nullptr instead of std::string, using file pointers without checking them for validity and similar things. This is not a complete list of issues, but the most dangerously looking ones.

@lazydroid lazydroid self-assigned this Sep 6, 2024
@rdiankov
Copy link
Owner

rdiankov commented Sep 6, 2024

Can you have Puttichai look at the changes related to planning? Thanks

@lazydroid
Copy link
Collaborator Author

lazydroid commented Sep 10, 2024

There's a conditional passing of NULL pointer with null pointer dereference, do you have any idea why do we need to convert vectors to raw pointers instead of just iterating over the vectors with the approximately same result?

image

@lazydroid lazydroid marked this pull request as ready for review October 22, 2024 09:02
Co-authored-by: Puttichai Lertkultanon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants