-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init variables, check for valid file pointers before using, provide valid return values #1424
Open
lazydroid
wants to merge
19
commits into
production
Choose a base branch
from
dev/lenik/init_variables_solvequadratic
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you have Puttichai look at the changes related to planning? Thanks |
cielavenir
reviewed
Sep 9, 2024
cielavenir
approved these changes
Sep 9, 2024
Puttichai
reviewed
Sep 9, 2024
lazydroid
commented
Sep 9, 2024
lazydroid
commented
Sep 10, 2024
lazydroid
commented
Sep 10, 2024
lazydroid
commented
Sep 10, 2024
lazydroid
commented
Sep 10, 2024
Puttichai
reviewed
Oct 23, 2024
Co-authored-by: Puttichai Lertkultanon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes minor issues in the using uninitialized variables, returning nullptr instead of std::string, using file pointers without checking them for validity and similar things. This is not a complete list of issues, but the most dangerously looking ones.