Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Save json with uri hint #1383

Open
wants to merge 3 commits into
base: production
Choose a base branch
from
Open

WIP: Save json with uri hint #1383

wants to merge 3 commits into from

Commits on May 3, 2024

  1. Use uriHint by default. 

    - Without uriHint, referenceUri is contained into saved json file.
- It seems the current jsonwriter only contains all the resolved bodies into one file, so referenceUri seems unnecessary.
- In addition, if saved referenceUri is unnecessarily contained,
   - When we load it on openrave, warning message is shown.
   - Other model loader software cannot load it because referenced file does not exist.
- I added noUriHint option. It's unnecessary right now, but in future, once we support file saving preserving the reference files, it might be necessary.
    Shunichi Nozawa committed May 3, 2024
    Configuration menu
    Copy the full SHA
    6a695ad View commit details
    Browse the repository at this point in the history

  2. Increment patch version for saving referenceUriHint

    Shunichi Nozawa committed May 3, 2024
    Configuration menu
    Copy the full SHA
    001f7f4 View commit details
    Browse the repository at this point in the history

  3. Resolve conflict while merge production. Conflict: CMakeLists.txt, ch… 

    …angelog.rst
    Shunichi Nozawa committed May 3, 2024
    Configuration menu
    Copy the full SHA
    74f93f8 View commit details
    Browse the repository at this point in the history