Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFS finalize_fit() support for numpy >= 2.0 #1107

Merged
merged 7 commits into from
Nov 3, 2024
Merged

SFS finalize_fit() support for numpy >= 2.0 #1107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4036e75
finalize_fit() support for numpy >= 2.0
d-kleine Oct 29, 2024
aeed2d8
updated changelog
d-kleine Oct 30, 2024
7cdb20d
flake8: removed blank line
d-kleine Oct 30, 2024
50d634f
flake8: removed trailing whitespaces
d-kleine Oct 30, 2024
99e0ecb
fixed changelog indents
d-kleine Oct 30, 2024
a1a9fe7
fix for isort / black formatter
d-kleine Oct 30, 2024
dbcce14
added change/feature description
d-kleine Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/sources/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@ Files updated:
- ['mlxtend.frequent_patterns.fpcommon']
- ['mlxtend.frequent_patterns.fpgrowth'](https://rasbt.github.io/mlxtend/user_guide/frequent_patterns/fpgrowth/)
- ['mlxtend.frequent_patterns.fpmax'](https://rasbt.github.io/mlxtend/user_guide/frequent_patterns/fpmax/)
- [`mlxtend.feature_selection.SequentialFeatureSelector`](https://github.com/rasbt/mlxtend/blob/master/mlxtend/feature_selection/sequential_feature_selector.py)
- Updated negative infinity constant to be compatible with old and new (>=2.0) `numpy` versions
- [`mlxtend.frequent_patterns.association_rules`](https://rasbt.github.io/mlxtend/user_guide/frequent_patterns/association_rules/)
- [`mlxtend.frequent_patterns.association_rules`](https://rasbt.github.io/mlxtend/user_guide/frequent_patterns/association_rules/)Implemented three new metrics: Jaccard, Certainty, and Kulczynski. ([#1096](https://github.com/rasbt/mlxtend/issues/1096))
- Integrated scikit-learn's `set_output` method into `TransactionEncoder` ([#1087](https://github.com/rasbt/mlxtend/issues/1087) via[it176131](https://github.com/it176131))
- Implemented three new metrics: Jaccard, Certainty, and Kulczynski. ([#1096](https://github.com/rasbt/mlxtend/issues/1096))
- Integrated scikit-learn's `set_output` method into `TransactionEncoder` ([#1087](https://github.com/rasbt/mlxtend/issues/1087) via [it176131](https://github.com/it176131))

##### Changes

Expand Down
8 changes: 6 additions & 2 deletions mlxtend/feature_selection/sequential_feature_selector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,11 @@ def fit(self, X, y, groups=None, **fit_params):
return self

def finalize_fit(self):
max_score = np.NINF
if np.__version__ < "2.0":
ninf = np.NINF
else:
ninf = -np.inf
max_score = ninf
for k in self.subsets_:
if (
k >= self.min_k
Expand All @@ -662,7 +666,7 @@ def finalize_fit(self):
best_subset = k

k_score = max_score
if k_score == np.NINF:
if k_score == ninf:
# i.e. all keys of self.subsets_ are not in interval `[self.min_k, self.max_k]`
# this happens if KeyboardInterrupt happens
keys = list(self.subsets_.keys())
Expand Down
Loading