-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SFS finalize_fit() support for numpy >= 2.0 #1107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example code for testing: import numpy as np
from sklearn.linear_model import LogisticRegression
from mlxtend.feature_selection import SequentialFeatureSelector as SFS
# Generate random values
np.random.seed(42) # For reproducibility
n_samples = 100 # Number of samples
n_features = 10 # Number of features
# Generate random features (X) and binary target (y)
X_train = np.random.rand(n_samples, n_features)
y_train = np.random.randint(0, 2, size=n_samples)
# Now run Sequential Feature Selection
sfs = SFS(LogisticRegression(),
k_features=5, # number of features to select
forward=True, # forward selection
floating=False, # no floating selection
scoring='accuracy',
verbose=5,
cv=5).fit(X_train, y_train) |
Great contribution |
@rasbt ready for review |
rasbt
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for fixing this!
rasbt
approved these changes
Nov 3, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update numpy negative infinity constant for version compatibility for the sequential feature selector (SFS)
np.NINF
for numpy <2.0 and-np.inf
for numpy >=2.0np.NINF
usage with version-aware variableThis change ensures the code works correctly across different numpy versions
while maintaining the same functionality.
Related issues or pull requests
fixes #1100 related issue
#1104 similar but incomplete PR
Pull Request Checklist
./docs/sources/CHANGELOG.md
file (if applicable)./mlxtend/*/tests
directories (if applicable)mlxtend/docs/sources/
(if applicable)PYTHONPATH='.' pytest ./mlxtend -sv
and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv
)flake8 ./mlxtend