Remove nx-cugraph build/test/publish from cugraph
#4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-rliu
added
improvement
eriknw
reviewed
Nov 7, 2024
jameslamb
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Great! This looks perfect, this should be enough to ensure we don't publish any more nx-cugraph 24.12 nightlies to the nightly PyPI index / rapidsai-nightly conda channel.
Up to you two, but I'd wait to merge this until we're ready to publish from the nx-cugraph repo.
raydouglass
approved these changes
Nov 12, 2024
bdice
approved these changes
Nov 12, 2024
eriknw
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Can we delete this FIXME now and PY_IGNORE_IMPORTMISMATCH=1? Or is this needed for other libraries?
Lines 30 to 34 in 2d1189b
Also, for posterity / reminder-to-self, docs are still in the cugraph repo:
cugraph/ci/release/update-version.sh
Line 121 in 2d1189b
I don't consider these blockers, so I'm going ahead and approving 🚀
|
/merge |
This was referenced Nov 12, 2024
jameslamb
added a commit
to rapidsai/rapids-metadata
that referenced
this pull request
Nov 13, 2024
In the 24.12 release, `nx-cugraph` is moving to its own repo: * https://github.com/rapidsai/nx-cugraph * rapidsai/cugraph#4748 This updates the 24.12 metadata to reflect that.
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
Similar to #4748, but for `cugraph-dgl` and `cugraph-pyg`. This PR removes all building, publishing, and testing code related to `cugraph-dgl` and `cugraph-pyg`. Those projects will very soon start publishing packages from https://github.com/rapidsai/cugraph-gnn instead. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Ralph Liu (https://github.com/nv-rliu) - Bradley Dice (https://github.com/bdice) URL: #4752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/rapidsai/graph_dl/issues/646
As part of the repo migration effort, this PR removes steps relevant to build/test/publish of
nx-cugraphfrom this repo.Changes are ready but just to be safe DO NOT MERGE until we begin publishing packages from the new repo.