Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nx-cugraph Package Publishing #16

Merged

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Nov 8, 2024

Closes https://github.com/rapidsai/graph_dl/issues/647

Updates build.yaml to enable building & publishing packages from this repo.

Scripts are copied from build.yaml from branch-24.12 in https://github.com/rapidsai/cugraph.

@nv-rliu nv-rliu added breaking Introduces a breaking change improvement Improves an existing functionality ci labels Nov 8, 2024
@nv-rliu nv-rliu requested a review from a team as a code owner November 8, 2024 20:06
@github-actions github-actions bot removed the ci label Nov 8, 2024
@nv-rliu
Copy link
Contributor Author

nv-rliu commented Nov 8, 2024

This should be merged once #15 is complete

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

To avoid blocking cugraph CI, I think we'll want to do this sequence:

  1. merge Remove nx-cugraph build/test/publish from cugraph cugraph#4748 (so it stops producing new packages)
  2. ask RAPIDS ops to delete all the previous 24.12 nightlies of nx-cugraph (both conda and wheels)
  3. merge this PR

@nv-rliu nv-rliu added the ci label Nov 12, 2024
@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 6a3ba40 into rapidsai:branch-24.12 Nov 13, 2024
30 checks passed
@nv-rliu nv-rliu deleted the b24.12-begin-publish-package branch November 13, 2024 16:57
rapids-bot bot pushed a commit that referenced this pull request Nov 15, 2024
Within this release, `nx-cugraph` moved from https://github.com/rapidsai/cugraph to this repo.

To avoid conflicts between nightlies produced from the different sources, CI scripts here were hard-coding the version for CI artifacts to `24.12.00a1000`. That should be removed now that this is the only repo packages are being published from (should have been removed in #16, sorry for missing it).

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Erik Welch (https://github.com/eriknw)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Ralph Liu (https://github.com/nv-rliu)
  - Erik Welch (https://github.com/eriknw)

URL: #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Introduces a breaking change ci improvement Improves an existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants