-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nx-cugraph
Package Publishing
#16
Merged
rapids-bot
merged 3 commits into
rapidsai:branch-24.12
from
nv-rliu:b24.12-begin-publish-package
Nov 13, 2024
Merged
Add nx-cugraph
Package Publishing
#16
rapids-bot
merged 3 commits into
rapidsai:branch-24.12
from
nv-rliu:b24.12-begin-publish-package
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-rliu
added
breaking
Introduces a breaking change
improvement
Improves an existing functionality
ci
labels
Nov 8, 2024
This should be merged once #15 is complete |
jameslamb
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
To avoid blocking cugraph
CI, I think we'll want to do this sequence:
- merge Remove
nx-cugraph
build/test/publish from cugraph cugraph#4748 (so it stops producing new packages) - ask RAPIDS ops to delete all the previous
24.12
nightlies ofnx-cugraph
(both conda and wheels) - merge this PR
bdice
approved these changes
Nov 12, 2024
eriknw
approved these changes
Nov 12, 2024
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
Within this release, `nx-cugraph` moved from https://github.com/rapidsai/cugraph to this repo. To avoid conflicts between nightlies produced from the different sources, CI scripts here were hard-coding the version for CI artifacts to `24.12.00a1000`. That should be removed now that this is the only repo packages are being published from (should have been removed in #16, sorry for missing it). Authors: - James Lamb (https://github.com/jameslamb) - Erik Welch (https://github.com/eriknw) Approvers: - Ray Douglass (https://github.com/raydouglass) - Ralph Liu (https://github.com/nv-rliu) - Erik Welch (https://github.com/eriknw) URL: #26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/rapidsai/graph_dl/issues/647
Updates
build.yaml
to enable building & publishing packages from this repo.Scripts are copied from
build.yaml
from branch-24.12 in https://github.com/rapidsai/cugraph.