Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy new copyright update script to all RAPIDS repos #30

Closed
KyleFromNVIDIA opened this issue Mar 11, 2024 · 6 comments
Closed

Deploy new copyright update script to all RAPIDS repos #30

KyleFromNVIDIA opened this issue Mar 11, 2024 · 6 comments
Labels
epic

Comments

@KyleFromNVIDIA
Copy link
Contributor

A new copyright update script was added to https://github.com/rapidsai/pre-commit-hooks, and v0.0.1 was tagged. This check has been deployed in cudf and cuspatial and seems to be working very well. We should deploy this to the rest of RAPIDS too.
@KyleFromNVIDIA KyleFromNVIDIA mentioned this issue Mar 11, 2024
Merged
KyleFromNVIDIA added a commit to KyleFromNVIDIA/rapids-cmake that referenced this issue Mar 11, 2024
@KyleFromNVIDIA
Replace local copyright check with pre-commit-hooks verify-copyright
01ed61d 
The local copyright.py script is bug-prone. Replace it with a more
robust centralized script from pre-commit-hooks.

Issue: rapidsai/build-planning#30
@KyleFromNVIDIA KyleFromNVIDIA mentioned this issue Mar 11, 2024
Merged
7 tasks
@bdice
Copy link
Contributor

bdice commented Mar 11, 2024

List of repos needing this: https://github.com/search?q=org%3Arapidsai%20copyright.py&type=code

  • cuml
  • rapids-cmake
  • raft
  • wholegraph
  • cudf-pandas-integration
  • cugraph-ops
  • cuvs
  • kvikio
  • cumlprims_mg

KyleFromNVIDIA added a commit to KyleFromNVIDIA/kvikio that referenced this issue Mar 11, 2024
@KyleFromNVIDIA
Replace local copyright check with pre-commit-hooks verify-copyright
dcc4a3e 
The local copyright.py script is bug-prone. Replace it with a more
robust centralized script from pre-commit-hooks.

Issue: rapidsai/build-planning#30
@KyleFromNVIDIA KyleFromNVIDIA mentioned this issue Mar 11, 2024
Merged
KyleFromNVIDIA added a commit to KyleFromNVIDIA/cuvs that referenced this issue Mar 11, 2024
@KyleFromNVIDIA
Replace local copyright check with pre-commit-hooks verify-copyright
294520b 
The local copyright.py script is bug-prone. Replace it with a more
robust centralized script from pre-commit-hooks.

Issue: rapidsai/build-planning#30
@KyleFromNVIDIA KyleFromNVIDIA mentioned this issue Mar 11, 2024
Merged
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this issue Mar 12, 2024
@KyleFromNVIDIA
Replace local copyright check with pre-commit-hooks verify-copyright (#…
c52ca52 
…5732)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Bradley Dice (https://github.com/bdice)

URL: #5732
KyleFromNVIDIA added a commit to KyleFromNVIDIA/raft that referenced this issue Mar 12, 2024
@KyleFromNVIDIA
Replace local copyright check with pre-commit-hooks verify-copyright
44f1cec 
The local copyright.py script is bug-prone. Replace it with a more
robust centralized script from pre-commit-hooks.

Issue: rapidsai/build-planning#30
@KyleFromNVIDIA KyleFromNVIDIA mentioned this issue Mar 12, 2024
Merged
KyleFromNVIDIA added a commit to KyleFromNVIDIA/wholegraph that referenced this issue Mar 12, 2024
@KyleFromNVIDIA
Replace local copyright check with pre-commit-hooks verify-copyright
5047061 
The local copyright.py script is bug-prone. Replace it with a more
robust centralized script from pre-commit-hooks.

Issue: rapidsai/build-planning#30
@KyleFromNVIDIA KyleFromNVIDIA mentioned this issue Mar 12, 2024
Merged
rapids-bot bot pushed a commit to rapidsai/wholegraph that referenced this issue Mar 12, 2024
@KyleFromNVIDIA
Replace local copyright check with pre-commit-hooks verify-copyright (#…
9466695 
…144)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #144
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this issue Mar 14, 2024
@KyleFromNVIDIA
Replace local copyright check with pre-commit-hooks verify-copyright (#…
c6b2a4d 
…352)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Mads R. B. Kristensen (https://github.com/madsbk)
  - Ray Douglass (https://github.com/raydouglass)

URL: #352
rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue Mar 18, 2024
@KyleFromNVIDIA
Replace local copyright check with pre-commit-hooks verify-copyright (#…
69fd971 
…2220)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #2220
rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this issue Mar 18, 2024
@KyleFromNVIDIA
Replace local copyright check with pre-commit-hooks verify-copyright (#…
75522d3 
…556)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #556
rapids-bot bot pushed a commit to rapidsai/cuvs that referenced this issue Mar 18, 2024
@KyleFromNVIDIA
Replace local copyright check with pre-commit-hooks verify-copyright (#…
964f686 
…48)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Ben Frederickson (https://github.com/benfred)
  - Ray Douglass (https://github.com/raydouglass)

URL: #48
@mroeschke
Copy link

If we are modifying/adding a file that has vendored code e.g. (python/cuml/_thirdparty/sklearn/preprocessing/_function_transformer.py), is it OK to still have the Nvidia copyright note at the top?

@KyleFromNVIDIA
Copy link
Contributor Author

My understanding is that versioneer.py has historically been exempt from the copyright notice, so precedent would say no. @bdice is that right?

@bdice
Copy link
Contributor

bdice commented Mar 20, 2024 •
edited
Loading

I’ll point you both to a resource about this offline.

@KyleFromNVIDIA There are a few references to copyright.py in developer guides for cuml and raft (possibly more). Just be aware to check for that too. They can be removed or updated for the pre-commit hook.

https://github.com/rapidsai/cuml/blob/334d7960a0690126a58e0be898cdceaa409686f2/wiki/cpp/DEVELOPER_GUIDE.md?plain=1#L202

https://github.com/rapidsai/raft/blob/0b9692b25f78cd1b27631e354e3f8921a976645c/docs/source/developer_guide.md?plain=1#L218

divyegala pushed a commit to divyegala/cuvs that referenced this issue Mar 20, 2024
@KyleFromNVIDIA @divyegala
Replace local copyright check with pre-commit-hooks verify-copyright (r…
de155b9 
…apidsai#48)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Ben Frederickson (https://github.com/benfred)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#48
benfred pushed a commit to benfred/cuvs that referenced this issue Apr 5, 2024
@KyleFromNVIDIA @benfred
Replace local copyright check with pre-commit-hooks verify-copyright (r…
e8c07f1 
…apidsai#48)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Ben Frederickson (https://github.com/benfred)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#48
@bdice
Copy link
Contributor

bdice commented Apr 13, 2024

It looks like we still have some clean to do here before we can close.

References can be seen in this search: https://github.com/search?q=org%3Arapidsai%20copyright.py&type=code

@KyleFromNVIDIA
Copy link
Contributor Author

rapidsai/wholegraph#149 removes the extra copyright script. I'll take a look at the others.

@KyleFromNVIDIA KyleFromNVIDIA mentioned this issue Apr 15, 2024
Merged
KyleFromNVIDIA added a commit to KyleFromNVIDIA/raft that referenced this issue Apr 15, 2024
@KyleFromNVIDIA
Update the developer's guide with new copyright hook
0c31abb 
Issue: rapidsai/build-planning#30
@KyleFromNVIDIA KyleFromNVIDIA mentioned this issue Apr 15, 2024
Merged
KyleFromNVIDIA added a commit to KyleFromNVIDIA/cuvs that referenced this issue Apr 15, 2024
@KyleFromNVIDIA
Update the developer's guide with new copyright hook
7d22338 
Issue: rapidsai/build-planning#30
@KyleFromNVIDIA KyleFromNVIDIA mentioned this issue Apr 15, 2024
Merged
rapids-bot bot pushed a commit to rapidsai/cuvs that referenced this issue Apr 15, 2024
@KyleFromNVIDIA
Update the developer's guide with new copyright hook (#81)
8df8c49 
Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Ben Frederickson (https://github.com/benfred)

URL: #81
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this issue Apr 15, 2024
@KyleFromNVIDIA
Update the developer's guide with new copyright hook (#5848)
c1791e1 
Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #5848
rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue Apr 15, 2024
@KyleFromNVIDIA
Update the developer's guide with new copyright hook (#2266)
da6e2a4 
Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #2266
@jameslamb jameslamb mentioned this issue May 3, 2024
Merged
3 tasks
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this issue May 6, 2024
@jameslamb
add RAPIDS copyright pre-commit hook (#1553)
c7fa7b1 
Contributes to rapidsai/build-planning#30.

Proposes adding the RAPIDS `verify-copyright` pre-commit hook, which automatically updates copyright dates for modified files.

This also fixes one date in a file from #1529.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #1553
@jakirkham jakirkham added the epic label May 21, 2024
difyrrwrzd added a commit to difyrrwrzd/cuvs that referenced this issue Aug 10, 2024
@difyrrwrzd
Replace local copyright check with pre-commit-hooks verify-copyright …
1ced6e3 
…(#48)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Ben Frederickson (https://github.com/benfred)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai/cuvs#48
difyrrwrzd added a commit to difyrrwrzd/cuvs that referenced this issue Aug 10, 2024
@difyrrwrzd
Update the developer's guide with new copyright hook (#81)
44db783 
Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Ben Frederickson (https://github.com/benfred)

URL: rapidsai/cuvs#81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jakirkham @bdice @mroeschke @KyleFromNVIDIA