Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace local copyright check with pre-commit-hooks verify-copyright #352

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Mar 11, 2024

The local copyright.py script is bug-prone. Replace it with a more robust centralized script from pre-commit-hooks.

Issue: rapidsai/build-planning#30

The local copyright.py script is bug-prone. Replace it with a more
robust centralized script from pre-commit-hooks.

Issue: rapidsai/build-planning#30
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner March 11, 2024 21:24
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 11, 2024
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @KyleFromNVIDIA

@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c6b2a4d into rapidsai:branch-24.04 Mar 14, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants