Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add RAPIDS copyright pre-commit hook #1553

Merged
merged 1 commit into from
May 6, 2024
Merged

add RAPIDS copyright pre-commit hook #1553

merged 1 commit into from
May 6, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#30.

Proposes adding the RAPIDS verify-copyright pre-commit hook, which automatically updates copyright dates for modified files.

This also fixes one date in a file from #1529.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 3, 2024
@jameslamb jameslamb requested a review from a team as a code owner May 3, 2024 20:47
@github-actions github-actions bot added CMake Python Related to RMM Python API labels May 3, 2024
KyleFromNVIDIA
KyleFromNVIDIA approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Not sure how we missed this one before.

@KyleFromNVIDIA
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit c7fa7b1 into rapidsai:branch-24.06 May 6, 2024
57 checks passed
@jameslamb jameslamb deleted the copyright-hook branch May 6, 2024 14:22
@jameslamb jameslamb mentioned this pull request May 16, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request May 16, 2024
@jameslamb
update copyright dates (#1564)
91d529f 
Updates some copyright dates. These were updated in 2024, but their copyright dates were not automatically modified because #1553 hadn't been merged yet.

On each file, I made a trivial change to convince the `verify-copyright` pre-commit hook that the files have changed.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameslamb @KyleFromNVIDIA @bdice