Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add how-to guide on application deletion #655
Add how-to guide on application deletion #655
Changes from 30 commits
dcb02a5
925d166
325e82a
6a34d27
8b4a572
34c00d2
0067b74
526b998
bce157b
e2bf749
098c00f
a3eb2c0
4328bef
3f4645d
c95a0fb
c23ec90
f74600e
39e9ec4
9f671b9
572d97e
7fdff3d
a6c107a
2c0480a
58f80e8
d4c8fba
f12b1f1
f37cde8
dd2bb32
74e6732
0ce1d25
2c55577
e51d4db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to call out the behavior of the default environment. If a user deployed their application to a non-default environment they already will know to set that flag. Plus any error message would guide them to the right behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retaining the environment part for completion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The namespace would only be
default-<app-name>
if the environment is setup with the default Kubernetes namespace. We can omit that detail and focus on the managed resources created by Radius.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we referencing Radius resources as managed resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was going back and forth on this. The term we use in the codebase is "rendered resources", but I had gotten feedback that readers may not want to use that term. Was trying to find a term that better describes what's happening without introducing a new "branded" term. Lemme see if I can reword this a little, as I want to describe what's happening without another proper adverb in Radius