Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how-to guide on application deletion #655

Merged
merged 32 commits into from
Aug 16, 2023
Merged

Add how-to guide on application deletion #655

merged 32 commits into from
Aug 16, 2023

Conversation

Reshrahim
Copy link
Contributor

@Reshrahim Reshrahim commented Jul 24, 2023

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Part 2 of #650 covers the Radius application deletion.

Auto-generated description

🤖 Generated by Copilot at 3f4645d

Summary

🚚📝🗑️

This pull request adds a new section to the docs called Deploying applications with pages for the rad deploy, rad run, and rad app delete commands. It also renames the Developing applications section to Authoring applications and moves the Developer environments page to the new section. Finally, it adjusts the weights of some sections and pages to change the order of the sidebar menu.

rad commands shine
Deploying apps in autumn
Docs reflect new terms

Walkthrough

  • Rename "Developing applications" section to "Authoring applications" (link)
  • Add new section "Deploying applications" with metadata and description (link)
  • Add new pages to "Deploying applications" section with content and examples for rad deploy, rad run, and rad app delete commands (link, link)
  • Move "Developer environments" page from "Authoring applications" section to "Deploying applications" section and change its weight (link)
  • Adjust the weights of "Community", "Contributing", "Operating environments", and "Reference" sections to reorder the sidebar menu (link, link, link, link)

Issue reference

Fixes #654

@Reshrahim Reshrahim requested a review from a team as a code owner July 24, 2023 19:06
@Reshrahim Reshrahim changed the base branch from v0.23 to edge July 24, 2023 19:07
@Reshrahim Reshrahim added the do-not-merge Do not merge this PR label Jul 24, 2023
@github-actions
Copy link

github-actions bot commented Jul 24, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

@Reshrahim Reshrahim removed the do-not-merge Do not merge this PR label Aug 10, 2023
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

@Reshrahim Reshrahim changed the title Add a page on application deletion Add how-to guide on application deletion Aug 10, 2023
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

Copy link
Contributor

@AaronCrawfis AaronCrawfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, couple small wording tweaks

docs/content/deploy-apps/delete-applications/index.md Outdated Show resolved Hide resolved
docs/content/deploy-apps/delete-applications/index.md Outdated Show resolved Hide resolved
docs/content/deploy-apps/delete-applications/index.md Outdated Show resolved Hide resolved
docs/content/deploy-apps/delete-applications/index.md Outdated Show resolved Hide resolved
docs/content/deploy-apps/delete-applications/index.md Outdated Show resolved Hide resolved
docs/content/deploy-apps/delete-applications/index.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

3 similar comments
@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

@Reshrahim Reshrahim linked an issue Aug 14, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

docs/content/deploy-apps/delete-applications/index.md Outdated Show resolved Hide resolved
rad app delete <appname>
```

This will delete the following resources from the default Radius environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will delete the following resources from the default Radius environment
This will delete:

I don't think we need to call out the behavior of the default environment. If a user deployed their application to a non-default environment they already will know to set that flag. Plus any error message would guide them to the right behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retaining the environment part for completion.


This will delete the following resources from the default Radius environment

1. All the resources created by Radius on the Kubernetes cluster under the `default-<app-name>` namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. All the resources created by Radius on the Kubernetes cluster under the `default-<app-name>` namespace
1. All managed resources created from Radius resources (_containers, gateways, etc._)

The namespace would only be default-<app-name> if the environment is setup with the default Kubernetes namespace. We can omit that detail and focus on the managed resources created by Radius.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we referencing Radius resources as managed resources?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was going back and forth on this. The term we use in the codebase is "rendered resources", but I had gotten feedback that readers may not want to use that term. Was trying to find a term that better describes what's happening without introducing a new "branded" term. Lemme see if I can reword this a little, as I want to describe what's happening without another proper adverb in Radius

docs/content/deploy-apps/delete-applications/index.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net
Password: Radiu$1234

@Reshrahim Reshrahim merged commit 2dcd1d5 into edge Aug 16, 2023
8 checks passed
@Reshrahim Reshrahim deleted the reshma/delete branch August 16, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify and document the deletion behavior for a Radius application
2 participants