-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add how-to guide on application deletion #655
Conversation
…into reshma/deploy
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, couple small wording tweaks
Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
3 similar comments
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
rad app delete <appname> | ||
``` | ||
|
||
This will delete the following resources from the default Radius environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will delete the following resources from the default Radius environment | |
This will delete: |
I don't think we need to call out the behavior of the default environment. If a user deployed their application to a non-default environment they already will know to set that flag. Plus any error message would guide them to the right behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retaining the environment part for completion.
|
||
This will delete the following resources from the default Radius environment | ||
|
||
1. All the resources created by Radius on the Kubernetes cluster under the `default-<app-name>` namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. All the resources created by Radius on the Kubernetes cluster under the `default-<app-name>` namespace | |
1. All managed resources created from Radius resources (_containers, gateways, etc._) |
The namespace would only be default-<app-name>
if the environment is setup with the default Kubernetes namespace. We can omit that detail and focus on the managed resources created by Radius.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we referencing Radius resources as managed resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was going back and forth on this. The term we use in the codebase is "rendered resources", but I had gotten feedback that readers may not want to use that term. Was trying to find a term that better describes what's happening without introducing a new "branded" term. Lemme see if I can reword this a little, as I want to describe what's happening without another proper adverb in Radius
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-655.westus2.azurestaticapps.net |
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Part 2 of #650 covers the Radius application deletion.
Auto-generated description
🤖 Generated by Copilot at 3f4645d
Summary
🚚📝🗑️
This pull request adds a new section to the docs called
Deploying applications
with pages for therad deploy
,rad run
, andrad app delete
commands. It also renames theDeveloping applications
section toAuthoring applications
and moves theDeveloper environments
page to the new section. Finally, it adjusts the weights of some sections and pages to change the order of the sidebar menu.Walkthrough
rad deploy
,rad run
, andrad app delete
commands (link, link)Issue reference
Fixes #654