-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Reorganise workflow yamls #267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a hierarchy of workflows that was not being fully utilised. This discards that structure in favour of the yaml file being organised by Kind and then by name. for i in `grep -lr "^kind: WorkflowTemplate"` ; do mv $i workflows/`cat "$i" | yq ".metadata.name"`.yaml done for i in `grep -lr "^kind: Sensor"` ; do mv $i sensors/`cat "$i" | yq ".metadata.name"`.yaml done etc
We don't use this structure any more.
These are separated out into folders by k8s namespace and then by "kind". Kustomization is added to manage these
When CI runs on a fork it doesn't have permissions to push there
stevekeay
force-pushed
the
reorganise-workflow-yamls
branch
from
September 11, 2024 11:44
957b8a7
to
286e942
Compare
stevekeay
force-pushed
the
reorganise-workflow-yamls
branch
from
September 11, 2024 11:58
2572223
to
26ad85b
Compare
stevekeay
force-pushed
the
reorganise-workflow-yamls
branch
3 times, most recently
from
September 11, 2024 12:23
ea04eba
to
a8b300f
Compare
stevekeay
force-pushed
the
reorganise-workflow-yamls
branch
from
September 11, 2024 12:48
a8b300f
to
51a3372
Compare
cardoe
changed the title
feat: Reorganise workflow yamls
chore: Reorganise workflow yamls
Sep 11, 2024
Annotations should only be required on kind: WorkflowTemplate and kind: CronWorkflowTemplate
stevekeay
force-pushed
the
reorganise-workflow-yamls
branch
from
September 12, 2024 14:05
97bcbce
to
f8dc624
Compare
cardoe
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #262, moved the branch to this repo because CI was failing on the fork.
PUC-505 #closes #comment or is it [PUC-505]